Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(791)

Unified Diff: pkg/analyzer/test/generated/utilities_test.dart

Issue 2407553002: Guard against exceptions thrown by linters (issue 27545) (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analyzer/test/generated/utilities_test.dart
diff --git a/pkg/analyzer/test/generated/utilities_test.dart b/pkg/analyzer/test/generated/utilities_test.dart
index 421949e282ae2b61a50bb2874ec083442b2e7e93..2c57df9fde21a01dbc24a47897b4ee29e69ff186 100644
--- a/pkg/analyzer/test/generated/utilities_test.dart
+++ b/pkg/analyzer/test/generated/utilities_test.dart
@@ -8,6 +8,7 @@ import 'dart:collection';
import 'package:analyzer/dart/ast/ast.dart';
import 'package:analyzer/dart/ast/token.dart';
+import 'package:analyzer/dart/ast/visitor.dart';
import 'package:analyzer/src/dart/ast/token.dart';
import 'package:analyzer/src/dart/ast/utilities.dart';
import 'package:analyzer/src/dart/scanner/reader.dart';
@@ -26,15 +27,16 @@ import 'test_support.dart';
main() {
defineReflectiveSuite(() {
defineReflectiveTests(AstClonerTest);
- defineReflectiveTests(NodeReplacerTest);
- defineReflectiveTests(LineInfoTest);
- defineReflectiveTests(SourceRangeTest);
defineReflectiveTests(BooleanArrayTest);
defineReflectiveTests(DirectedGraphTest);
+ defineReflectiveTests(ExceptionHandlingDelegatingAstVisitorTest);
+ defineReflectiveTests(LineInfoTest);
defineReflectiveTests(MultipleMapIteratorTest);
+ defineReflectiveTests(NodeReplacerTest);
defineReflectiveTests(SingleMapIteratorTest);
- defineReflectiveTests(TokenMapTest);
+ defineReflectiveTests(SourceRangeTest);
defineReflectiveTests(StringUtilitiesTest);
+ defineReflectiveTests(TokenMapTest);
});
}
@@ -1594,6 +1596,21 @@ class DirectedGraphTest extends EngineTestCase {
*/
class DirectedGraphTest_Node {}
+@reflectiveTest
+class ExceptionHandlingDelegatingAstVisitorTest extends EngineTestCase {
+ void test_handlerIsCalled() {
+ AstVisitor exceptionThrowingVisitor = new _ExceptionThrowingVisitor();
+ bool handlerInvoked = false;
+ AstVisitor visitor = new ExceptionHandlingDelegatingAstVisitor(
+ [exceptionThrowingVisitor], (AstNode node, AstVisitor visitor,
+ dynamic exception, StackTrace stackTrace) {
+ handlerInvoked = true;
+ });
+ new NullLiteral(null).accept(visitor);
+ expect(handlerInvoked, isTrue);
+ }
+}
+
class Getter_NodeReplacerTest_test_annotation
implements NodeReplacerTest_Getter<Annotation, ArgumentList> {
@override
@@ -4340,3 +4357,9 @@ class TokenMapTest {
expect(tokenMap.get(key), same(value));
}
}
+
+class _ExceptionThrowingVisitor extends SimpleAstVisitor {
+ visitNullLiteral(NullLiteral node) {
+ throw new ArgumentError('');
+ }
+}
« pkg/analyzer/lib/src/dart/ast/utilities.dart ('K') | « pkg/analyzer/lib/src/task/dart.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698