Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(441)

Unified Diff: pkg/analyzer/lib/src/task/dart.dart

Issue 2407553002: Guard against exceptions thrown by linters (issue 27545) (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analyzer/lib/src/task/dart.dart
diff --git a/pkg/analyzer/lib/src/task/dart.dart b/pkg/analyzer/lib/src/task/dart.dart
index e2345e2c6d7223cc12088d4e78776e173d43051a..88f9b512f50f04dfac4159ee47518ef3c713f48b 100644
--- a/pkg/analyzer/lib/src/task/dart.dart
+++ b/pkg/analyzer/lib/src/task/dart.dart
@@ -3249,12 +3249,10 @@ class GenerateLintsTask extends SourceBasedAnalysisTask {
// Prepare inputs.
//
CompilationUnit unit = getRequiredInput(RESOLVED_UNIT_INPUT);
-
//
// Generate lints.
//
List<AstVisitor> visitors = <AstVisitor>[];
-
bool timeVisits = analysisOptions.enableTiming;
List<Linter> linters = getLints(context);
int length = linters.length;
@@ -3269,10 +3267,9 @@ class GenerateLintsTask extends SourceBasedAnalysisTask {
visitors.add(visitor);
}
}
-
- DelegatingAstVisitor dv = new DelegatingAstVisitor(visitors);
- unit.accept(dv);
-
+ AstVisitor visitor = new ExceptionHandlingDelegatingAstVisitor(
+ visitors, ExceptionHandlingDelegatingAstVisitor.logException);
+ unit.accept(visitor);
//
// Record outputs.
//

Powered by Google App Engine
This is Rietveld 408576698