Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2407553002: Guard against exceptions thrown by linters (issue 27545) (Closed)

Created:
4 years, 2 months ago by Brian Wilkerson
Modified:
4 years, 2 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Guard against exceptions thrown by linters (issue 27545) R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/6446cab3913b4ec7f5c10047f0c6272ff8e6854c

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -781 lines) Patch
M pkg/analyzer/lib/dart/ast/visitor.dart View 1 chunk +7 lines, -771 lines 0 comments Download
M pkg/analyzer/lib/src/dart/ast/utilities.dart View 2 chunks +70 lines, -0 lines 1 comment Download
M pkg/analyzer/lib/src/task/dart.dart View 2 chunks +3 lines, -6 lines 0 comments Download
M pkg/analyzer/test/generated/utilities_test.dart View 4 chunks +27 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
4 years, 2 months ago (2016-10-07 21:07:35 UTC) #2
scheglov
LGTM https://codereview.chromium.org/2407553002/diff/1/pkg/analyzer/lib/src/dart/ast/utilities.dart File pkg/analyzer/lib/src/dart/ast/utilities.dart (right): https://codereview.chromium.org/2407553002/diff/1/pkg/analyzer/lib/src/dart/ast/utilities.dart#newcode25 pkg/analyzer/lib/src/dart/ast/utilities.dart:25: typedef void ExceptionInDelagateHandler( Delegate
4 years, 2 months ago (2016-10-07 21:16:44 UTC) #3
Brian Wilkerson
4 years, 2 months ago (2016-10-07 21:37:43 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
6446cab3913b4ec7f5c10047f0c6272ff8e6854c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698