Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Issue 2407523002: Update GN documentation. (Closed)

Created:
4 years, 2 months ago by Dirk Pranke
Modified:
4 years, 2 months ago
CC:
chromium-reviews, Dirk Pranke, tfarina, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update GN documentation. This CL updates the main GN page to reflect that the migration is basically done, and also adds documentation for the magic top-level "//:default" target (which we don't actually use in Chromium). R=brettw@chromium.org, kjellander@chromium.org Committed: https://crrev.com/e5e5a9dd1ca6b2d16db5ca08031ccade0654504f Cr-Commit-Position: refs/heads/master@{#423973}

Patch Set 1 : for initial review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -128 lines) Patch
M tools/gn/README.md View 2 chunks +14 lines, -51 lines 0 comments Download
M tools/gn/docs/faq.md View 2 chunks +15 lines, -76 lines 0 comments Download
M tools/gn/docs/language.md View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
Dirk Pranke
4 years, 2 months ago (2016-10-07 20:30:59 UTC) #2
brettw
lgtm
4 years, 2 months ago (2016-10-07 21:34:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2407523002/20001
4 years, 2 months ago (2016-10-07 21:35:15 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 2 months ago (2016-10-07 21:45:10 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/e5e5a9dd1ca6b2d16db5ca08031ccade0654504f Cr-Commit-Position: refs/heads/master@{#423973}
4 years, 2 months ago (2016-10-07 21:47:02 UTC) #8
kjellander_chromium
4 years, 2 months ago (2016-10-09 03:29:22 UTC) #9
Message was sent while issue was closed.
lgtm!

Powered by Google App Engine
This is Rietveld 408576698