Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(768)

Issue 2407483002: Make enable_service_discovery a chrome/ feature. (Closed)

Created:
4 years, 2 months ago by Lei Zhang
Modified:
4 years, 2 months ago
Reviewers:
brettw, Dan Beam
CC:
chromium-reviews, dbeam+watch-options_chromium.org, extensions-reviews_chromium.org, michaelpg+watch-options_chromium.org, Dirk Pranke, tfarina, agrieve+watch_chromium.org, asvitkine+watch_chromium.org, devtools-reviews_chromium.org, chromium-apps-reviews_chromium.org, pfeldman
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make enable_service_discovery a chrome/ feature. TBR=dbeam@chromium.org Committed: https://crrev.com/4888f2982142523a4a0ddacfbf729f8d23a11e98 Cr-Commit-Position: refs/heads/master@{#424019}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -76 lines) Patch
M build/config/BUILD.gn View 1 chunk +0 lines, -3 lines 0 comments Download
M build/config/features.gni View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/app/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/about_flags.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/devtools/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/devtools/device/devtools_android_bridge.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/mdns/dns_sd_registry.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/browser_context_keyed_service_factories.cc View 4 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/prefs/browser_prefs.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/profiles/chrome_browser_main_extra_parts_profiles.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options/browser_options_handler.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/options/browser_options_handler.cc View 8 chunks +9 lines, -10 lines 0 comments Download
M chrome/browser/ui/webui/print_preview/print_preview_handler.h View 9 chunks +9 lines, -11 lines 0 comments Download
M chrome/browser/ui/webui/print_preview/print_preview_handler.cc View 8 chunks +16 lines, -18 lines 0 comments Download
M chrome/common/BUILD.gn View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/common/extensions/api/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/features.gni View 3 chunks +11 lines, -8 lines 0 comments Download
M chrome/common/url_constants.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/docs/cookbook.md View 1 chunk +0 lines, -1 line 0 comments Download
M tools/grit/grit_rule.gni View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 20 (12 generated)
Lei Zhang
4 years, 2 months ago (2016-10-07 21:26:54 UTC) #6
brettw
lgtm
4 years, 2 months ago (2016-10-07 21:52:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2407483002/1
4 years, 2 months ago (2016-10-07 22:12:03 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/276867)
4 years, 2 months ago (2016-10-07 22:25:01 UTC) #11
Lei Zhang
TBR dbeam for a trivial change. chrome/browser/ui/webui/options/OWNERS is "set noparent" and are both owners are ...
4 years, 2 months ago (2016-10-07 22:31:46 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2407483002/1
4 years, 2 months ago (2016-10-07 22:32:43 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-07 23:58:15 UTC) #18
commit-bot: I haz the power
4 years, 2 months ago (2016-10-08 00:00:38 UTC) #20
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4888f2982142523a4a0ddacfbf729f8d23a11e98
Cr-Commit-Position: refs/heads/master@{#424019}

Powered by Google App Engine
This is Rietveld 408576698