Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Unified Diff: src/bootstrapper.cc

Issue 2407423002: [modules] Implement @@iterator on namespace objects. (Closed)
Patch Set: Rename kSize to kHeadersize again. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/ast/ast-types.cc ('k') | src/builtins/builtins.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/bootstrapper.cc
diff --git a/src/bootstrapper.cc b/src/bootstrapper.cc
index ff12defefb3b4c2c448cc2baee863dcce7c4ebc4..6b2f5abcc4bbfb468fdffa1cf439ace4622c5d8c 100644
--- a/src/bootstrapper.cc
+++ b/src/bootstrapper.cc
@@ -2161,18 +2161,27 @@ void Genesis::InitializeGlobal(Handle<JSGlobalObject> global_object,
Handle<Map> map =
factory->NewMap(JS_MODULE_NAMESPACE_TYPE, JSModuleNamespace::kSize);
Map::SetPrototype(map, isolate->factory()->null_value());
+ Map::EnsureDescriptorSlack(map, 2);
native_context()->set_js_module_namespace_map(*map);
- // Install @@toStringTag.
- PropertyAttributes attribs =
- static_cast<PropertyAttributes>(DONT_ENUM | READ_ONLY);
- DataConstantDescriptor d(factory->to_string_tag_symbol(),
- factory->NewStringFromAsciiChecked("Module"),
- attribs);
- Map::EnsureDescriptorSlack(map, 1);
- map->AppendDescriptor(&d);
+ { // Install @@toStringTag.
+ PropertyAttributes attribs =
+ static_cast<PropertyAttributes>(DONT_ENUM | READ_ONLY);
+ DataConstantDescriptor d(factory->to_string_tag_symbol(),
+ factory->NewStringFromAsciiChecked("Module"),
+ attribs);
+ map->AppendDescriptor(&d);
+ }
- // TODO(neis): Implement and install @@iterator.
+ { // Install @@iterator.
+ Handle<JSFunction> iterator = SimpleCreateFunction(
+ isolate, factory->NewStringFromAsciiChecked("[Symbol.iterator]"),
+ Builtins::kModuleNamespaceIterator, 0, true);
+ iterator->shared()->set_native(true);
+ // TODO(neis): Is this really supposed to be writable?
+ DataConstantDescriptor d(factory->iterator_symbol(), iterator, DONT_ENUM);
+ map->AppendDescriptor(&d);
+ }
}
{ // -- I t e r a t o r R e s u l t
@@ -2782,6 +2791,25 @@ void Bootstrapper::ExportFromRuntime(Isolate* isolate,
*generator_function_function);
}
+ { // -- F i x e d A r r a y I t e r a t o r
+ int size = JSFixedArrayIterator::kHeaderSize +
+ JSFixedArrayIterator::kInObjectPropertyCount * kPointerSize;
+ Handle<Map> map = factory->NewMap(JS_FIXED_ARRAY_ITERATOR_TYPE, size);
+ Map::SetPrototype(map, iterator_prototype);
+ Map::EnsureDescriptorSlack(map,
+ JSFixedArrayIterator::kInObjectPropertyCount);
+ map->SetInObjectProperties(JSFixedArrayIterator::kInObjectPropertyCount);
+ map->SetConstructor(native_context->object_function());
+
+ { // next
+ DataDescriptor d(factory->next_string(), JSFixedArrayIterator::kNextIndex,
+ DONT_ENUM, Representation::Tagged());
+ map->AppendDescriptor(&d);
+ }
+
+ native_context->set_fixed_array_iterator_map(*map);
+ }
+
{ // -- S e t I t e r a t o r
Handle<JSObject> set_iterator_prototype =
isolate->factory()->NewJSObject(isolate->object_function(), TENURED);
« no previous file with comments | « src/ast/ast-types.cc ('k') | src/builtins/builtins.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698