Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Unified Diff: src/objects.h

Issue 2407423002: [modules] Implement @@iterator on namespace objects. (Closed)
Patch Set: Update test262.status. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/heap/objects-visiting.cc ('k') | src/objects-body-descriptors-inl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/objects.h
diff --git a/src/objects.h b/src/objects.h
index e9f7c14232223b237179b59596a9c48482d4ad16..7f659049c88ae0d99e91a5a59595ea4ae8dd525a 100644
--- a/src/objects.h
+++ b/src/objects.h
@@ -72,6 +72,7 @@
// - JSDate
// - JSMessageObject
// - JSModuleNamespace
+// - JSFixedArrayIterator
// - JSProxy
// - FixedArrayBase
// - ByteArray
@@ -421,6 +422,7 @@ const int kStubMinorKeyBits = kSmiValueSize - kStubMajorKeyBits - 1;
V(JS_CONTEXT_EXTENSION_OBJECT_TYPE) \
V(JS_GENERATOR_OBJECT_TYPE) \
V(JS_MODULE_NAMESPACE_TYPE) \
+ V(JS_FIXED_ARRAY_ITERATOR_TYPE) \
V(JS_GLOBAL_OBJECT_TYPE) \
V(JS_GLOBAL_PROXY_TYPE) \
V(JS_API_OBJECT_TYPE) \
@@ -727,6 +729,7 @@ enum InstanceType {
JS_CONTEXT_EXTENSION_OBJECT_TYPE,
JS_GENERATOR_OBJECT_TYPE,
JS_MODULE_NAMESPACE_TYPE,
+ JS_FIXED_ARRAY_ITERATOR_TYPE,
JS_ARRAY_TYPE,
JS_ARRAY_BUFFER_TYPE,
JS_TYPED_ARRAY_TYPE,
@@ -982,6 +985,7 @@ template <class C> inline bool Is(Object* obj);
V(JSContextExtensionObject) \
V(JSGeneratorObject) \
V(JSModuleNamespace) \
+ V(JSFixedArrayIterator) \
V(Map) \
V(DescriptorArray) \
V(FrameArray) \
@@ -10436,6 +10440,37 @@ class JSStringIterator : public JSObject {
DISALLOW_IMPLICIT_CONSTRUCTORS(JSStringIterator);
};
+// A JS iterator over the elements of a FixedArray.
+// This corresponds to ListIterator in ecma262/#sec-createlistiterator.
+class JSFixedArrayIterator : public JSObject {
+ public:
+ DECLARE_CAST(JSFixedArrayIterator)
+ DECLARE_PRINTER(JSFixedArrayIterator)
+ DECLARE_VERIFIER(JSFixedArrayIterator)
+
+ // The array over which the iterator iterates.
+ DECL_ACCESSORS(array, FixedArray)
+
+ // The index of the array element that will be returned next.
+ DECL_INT_ACCESSORS(index)
+
+ // The initial value of the object's "next" property.
+ DECL_ACCESSORS(next, JSFunction)
Igor Sheludko 2016/10/13 11:58:27 Maybe call it initial_next to avoid confusion with
+
+ static const int kArrayOffset = JSObject::kHeaderSize;
+ static const int kIndexOffset = kArrayOffset + kPointerSize;
+ static const int kNextOffset = kIndexOffset + kPointerSize;
+ static const int kHeaderSize = kNextOffset + kPointerSize;
Igor Sheludko 2016/10/13 11:58:27 Please name it kSize to be consistent.
+
+ enum InObjectPropertyIndex {
+ kNextIndex,
+ kInObjectPropertyCount // Dummy.
+ };
+
+ private:
+ DISALLOW_IMPLICIT_CONSTRUCTORS(JSFixedArrayIterator);
+};
+
// OrderedHashTableIterator is an iterator that iterates over the keys and
// values of an OrderedHashTable.
//
« no previous file with comments | « src/heap/objects-visiting.cc ('k') | src/objects-body-descriptors-inl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698