Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 2407413004: [Mac] Make new tab button animation RTL-aware (Closed)

Created:
4 years, 2 months ago by lgrey
Modified:
4 years, 2 months ago
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make new tab button animation RTL-aware BUG=648559 Committed: https://crrev.com/fe4bf0ef14bf8210c68afe04d027c3ea7e0fc638 Cr-Commit-Position: refs/heads/master@{#425102}

Patch Set 1 #

Patch Set 2 : Stray #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -4 lines) Patch
M chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm View 1 1 chunk +7 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
lgrey
4 years, 2 months ago (2016-10-13 16:30:33 UTC) #3
Elly Fong-Jones
lgtm
4 years, 2 months ago (2016-10-13 16:33:59 UTC) #4
Mark Mentovai
LGTM
4 years, 2 months ago (2016-10-13 18:15:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2407413004/20001
4 years, 2 months ago (2016-10-13 18:16:47 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-13 18:37:47 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-10-13 18:40:51 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/fe4bf0ef14bf8210c68afe04d027c3ea7e0fc638
Cr-Commit-Position: refs/heads/master@{#425102}

Powered by Google App Engine
This is Rietveld 408576698