tools/bots/gn_build.py - Issue 2407413003: GN: Fix gn_build.py for Windows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/bots/gn_build.py

Issue 2407413003: GN: Fix gn_build.py for Windows (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/bots/gn_build.py

diff --git a/tools/bots/gn_build.py b/tools/bots/gn_build.py

index f7976526cd063da3be67d6785a848a71475162a1..0fe22989108b5863cc7864e752b28140344940ff 100644

--- a/tools/bots/gn_build.py

+++ b/tools/bots/gn_build.py

@@ -15,7 +15,9 @@ DART_ROOT = os.path.realpath(os.path.join(SCRIPT_DIR, '..', '..'))

def main(argv):

os.environ["DART_USE_GN"] = "1"

- gclient_result = subprocess.call(['gclient', 'runhooks'])

+ generate_buildfiles = os.path.join(

+ DART_ROOT, 'tools', 'generate_buildfiles.py')

+ gclient_result = subprocess.call(['python', generate_buildfiles])

if gclient_result != 0:

return gclient_result

« no previous file with comments | « no previous file | no next file » | no next file with comments »