Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(451)

Issue 2407413002: Fixed depth range of WebVR projection matrices (Closed)

Created:
4 years, 2 months ago by bajones
Modified:
4 years, 2 months ago
Reviewers:
klausw, mthiesse, bshe
CC:
chromium-reviews, blink-reviews, haraken
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixed depth range of WebVR projection matrices Accidentally used a matrix that assumed a [0, 1] depth range (which is what D3D uses) instead of OpenGL's [-1, 1] range. This effectively cut the depth precision in half. BUG=389343 Committed: https://crrev.com/cf3cd4e9863d31653dfdf1f9dfba1b7b7f1f1ae5 Cr-Commit-Position: refs/heads/master@{#424555}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M third_party/WebKit/Source/modules/vr/VRFrameData.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
bajones
Anyone want to rubber-stamp my this minor math tweak?
4 years, 2 months ago (2016-10-11 18:18:49 UTC) #2
mthiesse
lgtm
4 years, 2 months ago (2016-10-11 18:24:18 UTC) #3
klausw
On 2016/10/11 18:18:49, bajones (OOO-Paternity leave) wrote: > Anyone want to rubber-stamp my this minor ...
4 years, 2 months ago (2016-10-11 18:24:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2407413002/1
4 years, 2 months ago (2016-10-11 18:25:22 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-11 21:40:03 UTC) #7
commit-bot: I haz the power
4 years, 2 months ago (2016-10-11 21:43:46 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cf3cd4e9863d31653dfdf1f9dfba1b7b7f1f1ae5
Cr-Commit-Position: refs/heads/master@{#424555}

Powered by Google App Engine
This is Rietveld 408576698