Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Unified Diff: trunk/src/chrome/test/gpu/gpu_feature_browsertest.cc

Issue 24074005: Revert 223397 "Enable GPU blacklist in tests." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: trunk/src/chrome/test/gpu/gpu_feature_browsertest.cc
===================================================================
--- trunk/src/chrome/test/gpu/gpu_feature_browsertest.cc (revision 223455)
+++ trunk/src/chrome/test/gpu/gpu_feature_browsertest.cc (working copy)
@@ -189,8 +189,8 @@
class AcceleratedCompositingBlockedTest : public GpuFeatureTest {
public:
- virtual void SetUpOnMainThread() OVERRIDE {
- GpuFeatureTest::SetUpOnMainThread();
+ virtual void SetUpInProcessBrowserTestFixture() OVERRIDE {
+ GpuFeatureTest::SetUpInProcessBrowserTestFixture();
const std::string json_blacklist =
"{\n"
" \"name\": \"gpu blacklist\",\n"
@@ -216,7 +216,7 @@
#endif
IN_PROC_BROWSER_TEST_F(AcceleratedCompositingBlockedTest,
- MAYBE_AcceleratedCompositingBlocked) {
+ MAYBE_AcceleratedCompositingBlocked) {
EXPECT_TRUE(GpuDataManager::GetInstance()->IsFeatureBlacklisted(
gpu::GPU_FEATURE_TYPE_ACCELERATED_COMPOSITING));
@@ -366,18 +366,11 @@
if (gpu::GPUTestBotConfig::CurrentConfigMatches("XP"))
return;
- bool is_blacklisted = false;
-#if defined(OS_LINUX) && !defined(OS_CHROMEOS)
- // Blacklist rule #24 disables accelerated_2d_canvas on Linux.
- is_blacklisted = true;
-#endif
+ EXPECT_FALSE(GpuDataManager::GetInstance()->IsFeatureBlacklisted(
+ gpu::GPU_FEATURE_TYPE_ACCELERATED_2D_CANVAS));
- EXPECT_EQ(is_blacklisted,
- GpuDataManager::GetInstance()->IsFeatureBlacklisted(
- gpu::GPU_FEATURE_TYPE_ACCELERATED_2D_CANVAS));
-
const base::FilePath url(FILE_PATH_LITERAL("feature_canvas2d.html"));
- RunEventTest(url, kAcceleratedCanvasCreationEvent, !is_blacklisted);
+ RunEventTest(url, kAcceleratedCanvasCreationEvent, true);
}
IN_PROC_BROWSER_TEST_F(GpuFeatureTest, Canvas2DBlocked) {
« no previous file with comments | « trunk/src/chrome/test/base/test_launcher_utils.cc ('k') | trunk/src/content/browser/gpu/gpu_data_manager_impl_private.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698