Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(785)

Issue 24074005: Revert 223397 "Enable GPU blacklist in tests." (Closed)

Created:
7 years, 3 months ago by nasko
Modified:
7 years, 3 months ago
Reviewers:
gab
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 223397 "Enable GPU blacklist in tests." > Enable GPU blacklist in tests. > > Partial re-land of https://codereview.chromium.org/22198004/) -- Always enable FCM on Windows -- Part 1/3. > > On top of fixing some of the issues there; only lands the part that enables the GPU blacklist in tests as the former CL is too hard to land all at once. > > Also keeping --skip-gpu-data-loading around for now to be able to deal with failures caused in layout_tests by this on their own later (this needs to land ASAP and layout_tests don't need this ASAP). > > Another CL will follow to always enable FCM on non-blacklisted Windows machines. > > This part re-enables loading the blacklist in tests (and adds a content_browsertest to make sure that the configuration we expect to be testing is indeed the one we are testing -- this uncertainty is basically the only reason the blacklist was explicitly disabled before). > > This CL also cleans up compositor_util.cc which was enforcing the blacklist twice. > > The original plan was to do this only for Windows as Mac/Linux was causing trouble, but it turns out to be harder to do it only on Windows; so taking care of http://crbug.com/277242 in this CL too after all... > > BUG=233830, 267038, 190942, 277242 > TBR=jcivelli, piman > > Originally Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=219132 > Then Reverted: https://src.chromium.org/viewvc/chrome?view=rev&revision=219159 > > Then re-committed (part 1/3): https://src.chromium.org/viewvc/chrome?view=rev&revision=221114 > Reverted in: https://src.chromium.org/viewvc/chrome?view=rev&revision=221145 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222105 > > Review URL: https://chromiumcodereview.appspot.com/23534006 TBR=gab@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223456

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -96 lines) Patch
M trunk/src/chrome/browser/gpu/chrome_gpu_util.cc View 1 chunk +26 lines, -0 lines 0 comments Download
M trunk/src/chrome/test/base/test_launcher_utils.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/src/chrome/test/gpu/gpu_feature_browsertest.cc View 3 chunks +6 lines, -13 lines 0 comments Download
M trunk/src/content/browser/gpu/gpu_data_manager_impl_private.h View 1 chunk +0 lines, -3 lines 0 comments Download
M trunk/src/content/browser/gpu/gpu_data_manager_impl_private.cc View 4 chunks +5 lines, -35 lines 0 comments Download
M trunk/src/content/public/common/content_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/content/public/common/content_switches.cc View 2 chunks +1 line, -5 lines 0 comments Download
M trunk/src/content/public/test/browser_test_base.cc View 1 chunk +1 line, -3 lines 0 comments Download
M trunk/src/gpu/config/gpu_control_list.h View 3 chunks +0 lines, -8 lines 0 comments Download
M trunk/src/gpu/config/gpu_control_list.cc View 4 chunks +1 line, -11 lines 0 comments Download
M trunk/src/gpu/config/software_rendering_list_json.cc View 4 chunks +3 lines, -17 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
nasko
7 years, 3 months ago (2013-09-16 23:01:34 UTC) #1
nasko
7 years, 3 months ago (2013-09-16 23:03:30 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r223456.

Powered by Google App Engine
This is Rietveld 408576698