Turn on Analytic AA in Chrome

Turn on Analytic AA in Chrome

I'm closing this because there are too many files for the rietvelt to handle.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

[liyuqian, 2016-10-11 23:40:28]

Description was changed from

==========
Turn on Analytic AA in Chrome

BUG=
==========

to

==========
Turn on Analytic AA in Chrome

BUG=
==========

[liyuqian, 2016-10-11 23:40:28]

liyuqian@google.com changed reviewers:
+ fmalita@chromium.org

[liyuqian, 2016-10-11 23:40:47]

Will this trigger layout tests?

[liyuqian, 2016-10-11 23:41:35]

liyuqian@google.com changed reviewers:
+ bungeman@gmail.com, reed@google.com

[f(malita), 2016-10-12 01:37:41]

On 2016/10/11 23:40:47, liyuqian wrote:
> Will this trigger layout tests?

Doesn't look like it ran the layout tests, but it does show some unit test
failures.

To make sure it runs layout tests too, I suggest adding some whitespace to
third_party/WebKit/LayoutTests/TestExpectations.

[f(malita), 2016-10-12 03:43:13]

On 2016/10/12 01:37:41, f(malita) wrote:
> On 2016/10/11 23:40:47, liyuqian wrote:
> > Will this trigger layout tests?
> 
> Doesn't look like it ran the layout tests, but it does show some unit test
> failures.
> 
> To make sure it runs layout tests too, I suggest adding some whitespace to
> third_party/WebKit/LayoutTests/TestExpectations.

Never mind, the _blink bots did run layout tests => 2000+ diffs:
https://storage.googleapis.com/chromium-layout-test-archives/linux_precise_bl...

[chromium-reviews, 2016-10-12 03:45:19]

Thank you! Now the question is how do I handle those 2000+ diffs...

On Tue, Oct 11, 2016 at 8:43 PM, <fmalita@chromium.org> wrote:

> On 2016/10/12 01:37:41, f(malita) wrote:
> > On 2016/10/11 23:40:47, liyuqian wrote:
> > > Will this trigger layout tests?
> >
> > Doesn't look like it ran the layout tests, but it does show some unit
> test
> > failures.
> >
> > To make sure it runs layout tests too, I suggest adding some whitespace
> to
> > third_party/WebKit/LayoutTests/TestExpectations.
>
> Never mind, the _blink bots did run layout tests => 2000+ diffs:
> https://storage.googleapis.com/chromium-layout-test-
> archives/linux_precise_blink_rel/3708/layout-test-results/results.html
>
>
>
> https://codereview.chromium.org/2407393003/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[f(malita), 2016-10-13 15:09:43]

On 2016/10/12 03:45:19, chromium-reviews wrote:
> Thank you! Now the question is how do I handle those 2000+ diffs...

We can handle the pixel diffs one of two ways:

1) suppression + auto rebaseline (this is tedious as it requires fiddling with
the TestExpectations file)

2) manual rebasline using the new rebaseline-cl util
(https://groups.google.com/a/chromium.org/forum/#!topic/Blink-dev/A4HwldX-wFo)

I'm more concerned with the non-pixel failures:

a) ref test diffs (I see ~6 of them) - we may need to downgrade these to pixel
tests

b) layout unit test failures, e.g.
 
https://storage.googleapis.com/chromium-layout-test-archives/linux_precise_bl...

c) cc unit test failures, e.g.
 
https://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel...

[liyuqian, 2016-10-17 19:35:12]

Description was changed from

==========
Turn on Analytic AA in Chrome

BUG=
==========

to

==========
Turn on Analytic AA in Chrome

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[liyuqian, 2016-10-26 14:08:12]

I think that I've finally fixed all the tests! Please have a look at it and see
if I can land.

BTW, I got the following error during 'git cl upload' (but I can see my upload
in codereview).

400 status code.
  --> Failed to upload patch for
third_party/WebKit/LayoutTests/platform/mac/tables/mozilla/marvin/x_tfoot_align_center-expected.png.
Got 400 status code.
Traceback (most recent call last):
  File "/usr/local/google/home/liyuqian/skia/depot_tools/git_cl.py", line 5416,
in <module>
    sys.exit(main(sys.argv[1:]))
  File "/usr/local/google/home/liyuqian/skia/depot_tools/git_cl.py", line 5398,
in main
    return dispatcher.execute(OptionParser(), argv)
  File "/usr/local/google/home/liyuqian/skia/depot_tools/subcommand.py", line
252, in execute
    return command(parser, args[1:])
  File "/usr/local/google/home/liyuqian/skia/depot_tools/git_cl.py", line 4216,
in CMDupload
    return cl.CMDUpload(options, args, orig_args)
  File "/usr/local/google/home/liyuqian/skia/depot_tools/git_cl.py", line 1664,
in CMDUpload
    ret = self.CMDUploadChange(options, git_diff_args, change)
  File "/usr/local/google/home/liyuqian/skia/depot_tools/git_cl.py", line 2291,
in CMDUploadChange
    issue, patchset = upload.RealMain(upload_args)
  File "/usr/local/google/home/liyuqian/skia/depot_tools/third_party/upload.py",
line 2504, in RealMain
    result = UploadSeparatePatches(issue, rpc_server, patchset, data, options)
  File "/usr/local/google/home/liyuqian/skia/depot_tools/third_party/upload.py",
line 2104, in UploadSeparatePatches
    result = t.get(timeout=60)
  File "/usr/lib/python2.7/multiprocessing/pool.py", line 554, in get
    raise TimeoutError
multiprocessing.TimeoutError

[f(malita), 2016-10-26 16:51:35]

On 2016/10/26 14:08:12, liyuqian wrote:
> I think that I've finally fixed all the tests! Please have a look at it and
see
> if I can land.
> 

Awesome!

I went through some of the earlier diffs (the tricky border bleed cases in
particular), and they LGTM.  

See if you can land.  There's a good chance this will clash with other
CLs/rebaselines in flight, so it may take a few iterations.

I'm also a bit concerned that I cannot see any diffs for latest patch set - not
sure if the patch uploaded OK or not.  One way to find out :)

[f(malita), 2016-10-26 16:53:23]

You'll also need CC owner approval, but that part is trivial - I think it'd be
OK to TBR.

[chromium-reviews, 2016-10-26 17:45:16]

Thank you for the review! However, now all the try bots will fail because
of the patch failure (e.g.,
https://build.chromium.org/p/tryserver.blink/builders/linux_trusty_blink_rel/...)
so I don't think that I can land until that upload issue is fixed...

On Wed, Oct 26, 2016 at 12:53 PM, <fmalita@chromium.org> wrote:

> You'll also need CC owner approval, but that part is trivial - I think
> it'd be
> OK to TBR.
>
> https://codereview.chromium.org/2407393003/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[liyuqian, 2016-10-26 17:58:37]

Description was changed from

==========
Turn on Analytic AA in Chrome

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
Turn on Analytic AA in Chrome

I'm closing this because there are too many files for the rietvelt to handle.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========