Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Issue 2407393002: Remove MessageLoop::current() from ppapi/proxy. (Closed)

Created:
4 years, 2 months ago by fdoray
Modified:
4 years, 2 months ago
Reviewers:
piman
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove MessageLoop::current() from ppapi/proxy. Whenever possible, use ThreadTaskRunnerHandle::Get() instead of MessageLoop::current(). ThreadTaskRunnerHandle::Get() works within TaskScheduler while MessageLoop::current() doesn't. Good reasons to use MessageLoop::current(): - Add destruction, nesting or task observers. - Run nested loops. Bad reasons to use MessageLoop::current(): - Post tasks. Use ThreadTaskRunnerHandle::Get() instead. - Watch a file descriptor. Use FileDescriptorWatcher instead. - Verify that it is possible to post tasks to the current thread. Use ThreadTaskRunnerHandle::IsSet() instead. - Verify that code runs on a specific thread. Use SingleThreadTaskRunner::BelongsToCurrentThread() instead. BUG=650723 Committed: https://crrev.com/2111a57d06c915dce0a96bdfd2cffba284cf53c6 Cr-Commit-Position: refs/heads/master@{#424863}

Patch Set 1 #

Patch Set 2 : fix test error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -21 lines) Patch
M ppapi/proxy/plugin_globals.cc View 1 2 chunks +2 lines, -3 lines 0 comments Download
M ppapi/proxy/proxy_completion_callback_factory.h View 2 chunks +6 lines, -18 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
fdoray
PTAL
4 years, 2 months ago (2016-10-12 19:59:48 UTC) #10
piman
lgtm
4 years, 2 months ago (2016-10-12 20:50:29 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2407393002/20001
4 years, 2 months ago (2016-10-12 21:17:01 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-12 21:28:17 UTC) #14
commit-bot: I haz the power
4 years, 2 months ago (2016-10-12 21:31:41 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2111a57d06c915dce0a96bdfd2cffba284cf53c6
Cr-Commit-Position: refs/heads/master@{#424863}

Powered by Google App Engine
This is Rietveld 408576698