Enabling enable_vr_shell flag and tests on chromium.android

Enabling enable_vr_shell flag and tests on chromium.android

This enables the "enable_vr_shell" build flag that has been used on
chromium.fyi's "Android Builder (dbg)" builder without issue for some time.
https://build.chromium.org/p/chromium.fyi/builders/Android%20Builder%20%28dbg%29

This also enables the vr_shell_unittests tests that have been running on
chromium.fyi's "Android VR Tests" builder for a couple weeks.
https://build.chromium.org/p/chromium.fyi/builders/Android%20VR%20Tests

Original CL to add the tests: https://codereview.chromium.org/2356983002/

BUG=

Committed: https://crrev.com/23c165a3f056bd427662e794e39b86f35c5fc255
Cr-Commit-Position: refs/heads/master@{#424757}

[bsheedy, 2016-10-11 17:01:20]

bsheedy@chromium.org changed reviewers:
+ ben@chromium.org

[Ben Goodger (Google), 2016-10-11 17:26:27]

Description was changed from

==========
Enabling enable_vr_shell flag and tests on chromium.android

This enables the "enable_vr_shell" build flag that has been used on
chromium.fyi's "Android Builder (dbg)" builder without issue for some time.
https://build.chromium.org/p/chromium.fyi/builders/Android%20Builder%20%28dbg%29

This also enables the vr_shell_unittests tests that have been running on
chromium.fyi's "Android VR Tests" builder for a couple weeks.
https://build.chromium.org/p/chromium.fyi/builders/Android%20VR%20Tests

Original CL to add the tests: https://codereview.chromium.org/2356983002/

BUG=
==========

to

==========
Enabling enable_vr_shell flag and tests on chromium.android

This enables the "enable_vr_shell" build flag that has been used on
chromium.fyi's "Android Builder (dbg)" builder without issue for some time.
https://build.chromium.org/p/chromium.fyi/builders/Android%20Builder%20%28dbg%29

This also enables the vr_shell_unittests tests that have been running on
chromium.fyi's "Android VR Tests" builder for a couple weeks.
https://build.chromium.org/p/chromium.fyi/builders/Android%20VR%20Tests

Original CL to add the tests: https://codereview.chromium.org/2356983002/

BUG=
==========

[Ben Goodger (Google), 2016-10-11 17:26:28]

ben@chromium.org changed reviewers:
+ jam@chromium.org
- ben@chromium.org

[Ben Goodger (Google), 2016-10-11 17:26:35]

ben@chromium.org changed reviewers:
+ ben@chromium.org

[Ben Goodger (Google), 2016-10-11 17:26:35]

Redirecting to jam

[jam, 2016-10-11 19:21:48]

jam@chromium.org changed reviewers:
+ stip@chromium.org
- ben@chromium.org

[jam, 2016-10-11 19:21:49]

+stip as Android Infra guru

Note that all the tests on the android trybot are running swarmed, so you want
to copy that behavior.

[ghost stip (do not use), 2016-10-11 20:35:05]

in general lgtm. can you give me an idea of how long these tests take?

also, I believe this will conflict with
https://codereview.chromium.org/2409973002/

[ghost stip (do not use), 2016-10-11 20:41:08]

ah okay, looks like that conflict won't land today, so go ahead with this one

[bsheedy, 2016-10-11 21:09:45]

On 2016/10/11 20:35:05, stip wrote:
> in general lgtm. can you give me an idea of how long these tests take?
> 
> also, I believe this will conflict with
> https://codereview.chromium.org/2409973002/

According to the FYI tester's logs, the entire test step takes 18 seconds, and
the tests themselves only take 5 ms (there aren't many, and they're all very
fast).

Does everything still look good with the swarming changes pointed out by jam@?

[ghost stip (do not use), 2016-10-11 22:25:52]

yeah, I think so. we'll swarm them separately of this change

[bsheedy, 2016-10-11 22:26:59]

The CQ bit was checked by bsheedy@chromium.org

[bsheedy, 2016-10-11 22:26:59]

The patchset sent to the CQ was uploaded after l-g-t-m from stip@chromium.org
Link to the patchset: https://codereview.chromium.org/2407363002/#ps20001
(title: "Added swarming config for vr_shell_unittests on M 64 bit")

[commit-bot: I haz the power, 2016-10-11 22:27:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-11 22:37:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-11 22:37:22]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[bsheedy, 2016-10-11 22:41:34]

On 2016/10/11 22:25:52, stip wrote:
> yeah, I think so. we'll swarm them separately of this change

Patch #2 adds the same swarming config as all the other tests on that particular
builder. I can remove that if the swarming changes are to be done separately.

Also missing an lgtm from jam@ (or some other tools/mb/ owner) for the changes
to add the build flag.

[jam, 2016-10-12 15:50:42]

lgtm

[bsheedy, 2016-10-12 16:09:55]

The CQ bit was checked by bsheedy@chromium.org

[commit-bot: I haz the power, 2016-10-12 16:10:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-12 16:15:26]

Description was changed from

==========
Enabling enable_vr_shell flag and tests on chromium.android

This enables the "enable_vr_shell" build flag that has been used on
chromium.fyi's "Android Builder (dbg)" builder without issue for some time.
https://build.chromium.org/p/chromium.fyi/builders/Android%20Builder%20%28dbg%29

This also enables the vr_shell_unittests tests that have been running on
chromium.fyi's "Android VR Tests" builder for a couple weeks.
https://build.chromium.org/p/chromium.fyi/builders/Android%20VR%20Tests

Original CL to add the tests: https://codereview.chromium.org/2356983002/

BUG=
==========

to

==========
Enabling enable_vr_shell flag and tests on chromium.android

This enables the "enable_vr_shell" build flag that has been used on
chromium.fyi's "Android Builder (dbg)" builder without issue for some time.
https://build.chromium.org/p/chromium.fyi/builders/Android%20Builder%20%28dbg%29

This also enables the vr_shell_unittests tests that have been running on
chromium.fyi's "Android VR Tests" builder for a couple weeks.
https://build.chromium.org/p/chromium.fyi/builders/Android%20VR%20Tests

Original CL to add the tests: https://codereview.chromium.org/2356983002/

BUG=
==========

[commit-bot: I haz the power, 2016-10-12 16:15:27]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-12 16:17:48]

Description was changed from

==========
Enabling enable_vr_shell flag and tests on chromium.android

This enables the "enable_vr_shell" build flag that has been used on
chromium.fyi's "Android Builder (dbg)" builder without issue for some time.
https://build.chromium.org/p/chromium.fyi/builders/Android%20Builder%20%28dbg%29

This also enables the vr_shell_unittests tests that have been running on
chromium.fyi's "Android VR Tests" builder for a couple weeks.
https://build.chromium.org/p/chromium.fyi/builders/Android%20VR%20Tests

Original CL to add the tests: https://codereview.chromium.org/2356983002/

BUG=
==========

to

==========
Enabling enable_vr_shell flag and tests on chromium.android

This enables the "enable_vr_shell" build flag that has been used on
chromium.fyi's "Android Builder (dbg)" builder without issue for some time.
https://build.chromium.org/p/chromium.fyi/builders/Android%20Builder%20%28dbg%29

This also enables the vr_shell_unittests tests that have been running on
chromium.fyi's "Android VR Tests" builder for a couple weeks.
https://build.chromium.org/p/chromium.fyi/builders/Android%20VR%20Tests

Original CL to add the tests: https://codereview.chromium.org/2356983002/

BUG=

Committed: https://crrev.com/23c165a3f056bd427662e794e39b86f35c5fc255
Cr-Commit-Position: refs/heads/master@{#424757}
==========

[commit-bot: I haz the power, 2016-10-12 16:17:49]

Patchset 2 (id:??) landed as
https://crrev.com/23c165a3f056bd427662e794e39b86f35c5fc255
Cr-Commit-Position: refs/heads/master@{#424757}

[bsheedy, 2016-10-12 17:33:05]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2419543003/ by bsheedy@chromium.org.

The reason for reverting is: 64 bit builder failed
https://build.chromium.org/p/chromium.android/builders/Android%20arm64%20Buil...

This is the only change in the blamelist that seems to affect the inclusion of
new libraries, so it's the most suspect. Works fine with the 32 bit builder, so
will have to figure out why 64 bit doesn't like the VR libraries..

[Ted C, 2016-10-12 17:34:05]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2410943004/ by tedchoc@chromium.org.

The reason for reverting is: Android arm64 Builder started failing:

https://build.chromium.org/p/chromium.android/builders/Android%20arm64%20Buil...

Nothing super obvious in that list of changes, but this specifically calls out
chromium.android..

[bsheedy, 2016-10-12 17:53:38]

On 2016/10/12 17:34:05, Ted C wrote:
> A revert of this CL (patchset #2 id:20001) has been created in
> https://codereview.chromium.org/2410943004/ by mailto:tedchoc@chromium.org.
> 
> The reason for reverting is: Android arm64 Builder started failing:
> 
>
https://build.chromium.org/p/chromium.android/builders/Android%20arm64%20Buil...
> 
> Nothing super obvious in that list of changes, but this specifically calls out
> chromium.android..

It turns out the crazy linker and VR Shell don't play nice since the linker only
likes having a single .so (but only on 64 bit apparently? 32 bit and the FYI bot
this was enabled on were fine). There's a .a in the works that should fix the
issue (as well as reducing the binary size), but it's been delayed a bit. I was
aware that a .a was in the works, but thought it only addressed the binary size.
Will attempt re-land patch after that is in.