Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 2407313003: Use arraysize() instead of hardcoded kSize constants in api-natives.cc (Closed)

Created:
4 years, 2 months ago by adamk
Modified:
4 years, 2 months ago
Reviewers:
gsathya
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Use arraysize() instead of hardcoded kSize constants in api-natives.cc R=gsathya@chromium.org Committed: https://crrev.com/6de9439f81c750ca4ff526516ea8ccb389e40884 Cr-Commit-Position: refs/heads/master@{#40187}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -9 lines) Patch
M src/api-natives.cc View 2 chunks +6 lines, -9 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
adamk
4 years, 2 months ago (2016-10-11 19:44:35 UTC) #1
gsathya
lgtm
4 years, 2 months ago (2016-10-11 19:45:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2407313003/1
4 years, 2 months ago (2016-10-11 19:45:32 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-11 20:17:18 UTC) #5
commit-bot: I haz the power
4 years, 2 months ago (2016-10-11 20:17:51 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6de9439f81c750ca4ff526516ea8ccb389e40884
Cr-Commit-Position: refs/heads/master@{#40187}

Powered by Google App Engine
This is Rietveld 408576698