Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1710)

Unified Diff: content/public/android/java/src/org/chromium/content/browser/ContentViewClient.java

Issue 2407303005: Let embedder provide select action mode (Closed)
Patch Set: fixing tests Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/android/java/src/org/chromium/content/browser/ContentViewClient.java
diff --git a/content/public/android/java/src/org/chromium/content/browser/ContentViewClient.java b/content/public/android/java/src/org/chromium/content/browser/ContentViewClient.java
index 479d60da470f0a097af570c387011f8867cc4f57..a487cfee3e3765a9612bb62ca83b7b3390bc7537 100644
--- a/content/public/android/java/src/org/chromium/content/browser/ContentViewClient.java
+++ b/content/public/android/java/src/org/chromium/content/browser/ContentViewClient.java
@@ -85,63 +85,6 @@ public class ContentViewClient {
}
/**
- * Called when the contextual ActionBar is shown.
- */
- public void onContextualActionBarShown() {
- }
-
- /**
- * Called when the contextual ActionBar is hidden.
- */
- public void onContextualActionBarHidden() {
- }
-
- /**
- * Perform a search on {@code searchQuery}. This method is only called if
- * {@link #doesPerformWebSearch()} returns {@code true}.
- * @param searchQuery The string to search for.
- */
- public void performWebSearch(String searchQuery) {
- }
-
- /**
- * If this returns {@code true} contextual web search attempts will be forwarded to
- * {@link #performWebSearch(String)}.
- * @return {@code true} iff this {@link ContentViewClient} wants to consume web search queries
- * and override the default intent behavior.
- */
- public boolean doesPerformWebSearch() {
- return false;
- }
-
- /**
- * If this returns {@code true} the text processing intents should be forwarded to {@link
- * startProcessTextIntent(Intent)}, otherwise these intents should be sent by WindowAndroid by
- * default.
- * @return {@code true} iff this {@link ContentViewClient} wants to send the processing intents
- * and override the default intent behavior.
- */
- public boolean doesPerformProcessText() {
- return false;
- }
-
- /**
- * Send the intent to process the current selected text.
- */
- public void startProcessTextIntent(Intent intent) {}
-
- /**
- * @param actionModeItem the flag for the action mode item in question. See
- * {@link WebActionModeCallback.ActionHandler} for a list of valid action
- * mode item flags.
- * @return true if the action is allowed. Otherwise, the menu item
- * should be removed from the menu.
- */
- public boolean isSelectActionModeAllowed(int actionModeItem) {
- return true;
- }
-
- /**
* Called when a new content intent is requested to be started.
*/
public void onStartContentIntent(Context context, String intentUrl, boolean isMainFrame) {

Powered by Google App Engine
This is Rietveld 408576698