chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchTapEventTest.java - Issue 2407303005: Let embedder provide select action mode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchTapEventTest.java

Issue 2407303005: Let embedder provide select action mode (Closed)

Patch Set: fixing tests Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagerTest.java ('k') | content/browser/android/content_view_core_impl.h » ('j') | content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchTapEventTest.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchTapEventTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchTapEventTest.java

index 577c2c35af1874e2b7db7d43ff8e8859a95dfe94..bd0278e76e96208c84dc8160ffea7f8177775f5b 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchTapEventTest.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchTapEventTest.java

@@ -23,6 +23,7 @@ import org.chromium.chrome.browser.compositor.layouts.eventfilter.EventFilterHos

import org.chromium.chrome.test.ChromeActivityTestCaseBase;

import org.chromium.content.browser.ContentViewCore;

import org.chromium.content.browser.ContextualSearchClient;

+import org.chromium.content.browser.SelectionPopupController;

import org.chromium.content_public.browser.WebContents;

import org.chromium.ui.base.WindowAndroid;

import org.chromium.ui.resources.dynamics.DynamicResourceLoader;

@@ -86,7 +87,11 @@ public class ContextualSearchTapEventTest extends ChromeActivityTestCaseBase<Chr

WindowAndroid windowAndroid) {

super(activity, windowAndroid, null);

setSelectionController(new MockCSSelectionController(activity, this));

- getSelectionController().getBaseContentView().setContextualSearchClient(this);

+ ContentViewCore contentView = getSelectionController().getBaseContentView();

+ contentView.setSelectionPopupControllerForTesting(

+ new SelectionPopupController(activity, null, null, null,

+ contentView.getRenderCoordinates(), null));

+ contentView.setContextualSearchClient(this);

MockContextualSearchPolicy policy = new MockContextualSearchPolicy(activity);

setContextualSearchPolicy(policy);

mTranslateController = new MockedCSTranslateController(activity, policy, null);