chrome/android/java/src/org/chromium/chrome/browser/omnibox/UrlBar.java - Issue 2407303005: Let embedder provide select action mode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/omnibox/UrlBar.java

Issue 2407303005: Let embedder provide select action mode (Closed)

Patch Set: fixing tests Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ChromeActionModeCallback.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java » ('j') | content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/omnibox/UrlBar.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/omnibox/UrlBar.java b/chrome/android/java/src/org/chromium/chrome/browser/omnibox/UrlBar.java

index dc398e4e3bc133d7b830c85964a2d650f0231a35..d97f1c4adc7ea07ef1a32fbc72fa3d2af2ddf8f3 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/omnibox/UrlBar.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/omnibox/UrlBar.java

@@ -534,7 +534,7 @@ public class UrlBar extends VerticallyFixedEditText {

if (event.getAction() == MotionEvent.ACTION_DOWN && currentTab != null) {

// Make sure to hide the current ContentView ActionBar.

ContentViewCore viewCore = currentTab.getContentViewCore();

- if (viewCore != null) viewCore.hideSelectActionMode();

+ if (viewCore != null) viewCore.destroySelectActionMode();

}

return super.onTouchEvent(event);