content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java - Issue 2407303005: Let embedder provide select action mode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java

Issue 2407303005: Let embedder provide select action mode (Closed)

Patch Set: more comments addressed Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/public/android/java/src/org/chromium/content/browser/WebActionMode.java ('K') | « content/public/android/java/src/org/chromium/content/browser/input/FloatingPastePopupMenu.java ('k') | content/public/android/java/src/org/chromium/content_public/browser/WebContents.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java

diff --git a/content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java b/content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java

index 73aa41ce902e84547551dd476836384c00329398..12a8bf6229929ba843447844739aa00f1f286ad2 100644

--- a/content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java

+++ b/content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java

@@ -474,6 +474,11 @@ import java.util.UUID;

callback.onFinishDownloadImage(id, httpStatusCode, imageUrl, bitmaps, sizes);

}

+ @Override

+ public void dismissTextHandles() {

+ nativeDismissTextHandles(mNativeWebContentsAndroid);

+ }

@CalledByNative

private static List<Bitmap> createBitmapList() {

return new ArrayList<Bitmap>();

@@ -557,4 +562,5 @@ import java.util.UUID;

private native int nativeDownloadImage(long nativeWebContentsAndroid,

String url, boolean isFavicon, int maxBitmapSize,

boolean bypassCache, ImageDownloadCallback callback);

+ private native void nativeDismissTextHandles(long nativeWebContentsAndroid);

}