chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java - Issue 2407303005: Let embedder provide select action mode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java

Issue 2407303005: Let embedder provide select action mode (Closed)

Patch Set: more comments addressed Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java ('k') | chrome/android/java_sources.gni » ('j') | content/public/android/java/src/org/chromium/content/browser/FloatingWebActionModeCallback.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java b/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java

index bb3e4a154ac16b35e4cdbae267117ff0b311a779..26b231530e3a265f8ccd7813905be7666414b641 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java

@@ -37,6 +37,7 @@ import org.chromium.chrome.browser.WebContentsFactory;

import org.chromium.chrome.browser.tab.Tab;

import org.chromium.content.browser.ContentView;

import org.chromium.content.browser.ContentViewCore;

+import org.chromium.content.browser.WebActionMode;

import org.chromium.content_public.browser.WebContents;

import org.chromium.ui.base.ViewAndroidDelegate;

import org.chromium.ui.base.WindowAndroid;

@@ -125,7 +126,8 @@ public class VrShellImpl extends GvrLayout implements GLSurfaceView.Renderer, Vr

mUiCVC = new ContentViewCore(mActivity, ChromeVersionInfo.getProductVersion());

ContentView uiContentView = ContentView.createContentView(mActivity, mUiCVC);

mUiCVC.initialize(ViewAndroidDelegate.createBasicDelegate(uiContentView),

- uiContentView, mUiContents, mUiVrWindowAndroid);

+ uiContentView, mUiContents, mUiVrWindowAndroid,

+ WebActionMode.EMPTY_CALLBACK);

mNativeVrShell = nativeInit(mContentCVC.getWebContents(),

mContentVrWindowAndroid.getNativePointer(),