chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanelContent.java - Issue 2407303005: Let embedder provide select action mode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanelContent.java

Issue 2407303005: Let embedder provide select action mode (Closed)

Patch Set: more comments addressed Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ChromeActionModeCallback.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/omnibox/UrlBar.java » ('j') | content/public/android/java/src/org/chromium/content/browser/FloatingWebActionModeCallback.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanelContent.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanelContent.java b/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanelContent.java

index a10f0563852937587207b87c514607c2a6acf1c7..c9c5067c780730452f513ecf2fdd88b5cc794e2e 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanelContent.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanelContent.java

@@ -23,6 +23,7 @@ import org.chromium.content.browser.ContentVideoViewEmbedder;

import org.chromium.content.browser.ContentView;

import org.chromium.content.browser.ContentViewClient;

import org.chromium.content.browser.ContentViewCore;

+import org.chromium.content.browser.WebActionMode;

import org.chromium.content_public.browser.LoadUrlParams;

import org.chromium.content_public.browser.WebContents;

import org.chromium.content_public.browser.WebContentsObserver;

@@ -268,7 +269,8 @@ public class OverlayPanelContent {

return mContainerView;

}

}.init(cv);

- mContentViewCore.initialize(delegate, cv, panelWebContents, mActivity.getWindowAndroid());

+ mContentViewCore.initialize(delegate, cv, panelWebContents, mActivity.getWindowAndroid(),

+ WebActionMode.EMPTY_CALLBACK);

// Transfers the ownership of the WebContents to the native OverlayPanelContent.

nativeSetWebContents(mNativeOverlayPanelContentPtr, panelWebContents, mWebContentsDelegate);