android_webview/javatests/src/org/chromium/android_webview/test/PopupWindowTest.java - Issue 2407303005: Let embedder provide select action mode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/javatests/src/org/chromium/android_webview/test/PopupWindowTest.java

Issue 2407303005: Let embedder provide select action mode (Closed)

Patch Set: Move FloatingPaste into WebActionMode Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/java/src/org/chromium/android_webview/AwContents.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/ChromeActionModeCallback.java » ('j') | content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/javatests/src/org/chromium/android_webview/test/PopupWindowTest.java

diff --git a/android_webview/javatests/src/org/chromium/android_webview/test/PopupWindowTest.java b/android_webview/javatests/src/org/chromium/android_webview/test/PopupWindowTest.java

index 32575e6fd9920912651a258cc4b03d0cadaeef4e..e739efc45eb3bee6a770b92f2a8d8e37d2fbcea9 100644

--- a/android_webview/javatests/src/org/chromium/android_webview/test/PopupWindowTest.java

+++ b/android_webview/javatests/src/org/chromium/android_webview/test/PopupWindowTest.java

@@ -157,7 +157,7 @@ public class PopupWindowTest extends AwTestBase {

getInstrumentation().runOnMainSync(new Runnable() {

@Override

public void run() {

- cvc.hideSelectActionMode();

+ cvc.destroySelectActionMode();

}

});

}