exo: Use WMHelper to access ash accessibility related features.

exo: Use WMHelper to access ash accessibility related features.

BUG=637914
Committed: https://crrev.com/5fe276a24193a33a46a4eab6abdc2f9888960839
Cr-Commit-Position: refs/heads/master@{#424735}

[Peng, 2016-10-11 18:57:25]

penghuang@chromium.org changed reviewers:
+ reveman@chromium.org

[Peng, 2016-10-11 18:57:26]

Hi David, PTAL, Thanks.

[Peng, 2016-10-11 18:57:43]

The CQ bit was checked by penghuang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-11 18:58:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-11 19:55:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-11 19:55:33]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[reveman, 2016-10-12 13:56:13]

lgtm

[Peng, 2016-10-12 14:25:17]

The CQ bit was checked by penghuang@chromium.org

[Peng, 2016-10-12 14:25:17]

The patchset sent to the CQ was uploaded after l-g-t-m from reveman@chromium.org
Link to the patchset: https://codereview.chromium.org/2407303003/#ps20001
(title: "Fix compile errors.")

[commit-bot: I haz the power, 2016-10-12 14:25:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-12 14:49:46]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-12 14:52:32]

Description was changed from

==========
exo: Use WMHelper to access ash accessibility related features.

BUG=637914
==========

to

==========
exo: Use WMHelper to access ash accessibility related features.

BUG=637914

Committed: https://crrev.com/5fe276a24193a33a46a4eab6abdc2f9888960839
Cr-Commit-Position: refs/heads/master@{#424735}
==========

[commit-bot: I haz the power, 2016-10-12 14:52:32]

Patchset 2 (id:??) landed as
https://crrev.com/5fe276a24193a33a46a4eab6abdc2f9888960839
Cr-Commit-Position: refs/heads/master@{#424735}

[David Tseng, 2017-01-17 22:43:41]

dtseng@chromium.org changed reviewers:
+ dtseng@chromium.org

[David Tseng, 2017-01-17 22:43:41]

https://codereview.chromium.org/2407303003/diff/20001/components/exo/shell_su...
File components/exo/shell_surface.cc (left):

https://codereview.chromium.org/2407303003/diff/20001/components/exo/shell_su...
components/exo/shell_surface.cc:1077:
ash::WmShell::Get()->system_tray_notifier()->AddAccessibilityObserver(this);
I don't understand how your cl replaces this observer call. WmHelper adds a
*new* AccessibilityObserver interface which does get called, but the
ash::AccessibilityObserver never gets called, since it never adds itself to
observe this particular line?

Am I missing something?

[Peng, 2017-01-18 20:49:47]

On 2017/01/17 22:43:41, David Tseng wrote:
>
https://codereview.chromium.org/2407303003/diff/20001/components/exo/shell_su...
> File components/exo/shell_surface.cc (left):
> 
>
https://codereview.chromium.org/2407303003/diff/20001/components/exo/shell_su...
> components/exo/shell_surface.cc:1077:
> ash::WmShell::Get()->system_tray_notifier()->AddAccessibilityObserver(this);
> I don't understand how your cl replaces this observer call. WmHelper adds a
> *new* AccessibilityObserver interface which does get called, but the
> ash::AccessibilityObserver never gets called, since it never adds itself to
> observe this particular line?
> 
> Am I missing something?

Oops! I will fix this issue.