Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 2407303002: [stubs] Renames WordIsSmi to TaggedIsSmi, introducing an appropriate bitcast of the parameter. (Closed)

Created:
4 years, 2 months ago by epertoso
Modified:
4 years, 2 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, rmcilroy
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[stubs] Renames WordIsSmi to TaggedIsSmi, introducing an appropriate bitcast of the parameter. WordIsSmi, by itself, is not that descriptive, as it just ands a word with the heap object tag. With this change, the MachineGraphVerifier can check that the input to TaggedIsSmi actually has a tagged representation. This CL also introduces a few bitcast operators in the Smi* macros in the CodeStubAssembler. R=bmeurer@chromium.org BUG= Committed: https://crrev.com/87cc641e8c24b62ddb61306efe54b9bcb1be9cf3 Cr-Commit-Position: refs/heads/master@{#40209}

Patch Set 1 #

Patch Set 2 : Renamed TaggedValueIsSmi to TaggedIsSmi. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+209 lines, -178 lines) Patch
M src/builtins/builtins-array.cc View 1 18 chunks +22 lines, -18 lines 0 comments Download
M src/builtins/builtins-conversion.cc View 1 6 chunks +6 lines, -6 lines 0 comments Download
M src/builtins/builtins-date.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/builtins/builtins-generator.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/builtins/builtins-global.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/builtins/builtins-math.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/builtins/builtins-number.cc View 1 15 chunks +23 lines, -20 lines 0 comments Download
M src/builtins/builtins-object.cc View 1 4 chunks +4 lines, -4 lines 0 comments Download
M src/builtins/builtins-regexp.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M src/builtins/builtins-sharedarraybuffer.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/builtins/builtins-string.cc View 1 6 chunks +7 lines, -6 lines 0 comments Download
M src/builtins/builtins-typedarray.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/code-stub-assembler.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/code-stub-assembler.cc View 1 49 chunks +79 lines, -65 lines 0 comments Download
M src/code-stubs.cc View 1 19 chunks +33 lines, -26 lines 0 comments Download
M src/interpreter/interpreter.cc View 1 9 chunks +10 lines, -10 lines 0 comments Download
M src/interpreter/interpreter-assembler.cc View 1 5 chunks +5 lines, -5 lines 0 comments Download
M src/interpreter/interpreter-intrinsics.cc View 1 5 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
Benedikt Meurer
lgtm
4 years, 2 months ago (2016-10-12 09:21:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2407303002/20001
4 years, 2 months ago (2016-10-12 09:31:27 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-12 10:00:48 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-10-12 10:01:08 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/87cc641e8c24b62ddb61306efe54b9bcb1be9cf3
Cr-Commit-Position: refs/heads/master@{#40209}

Powered by Google App Engine
This is Rietveld 408576698