Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issue 2407243004: Fix Polymer's Chrome-specific patch (Closed)

Created:
4 years, 2 months ago by Dan Beam
Modified:
4 years, 2 months ago
Reviewers:
dpapad
CC:
chromium-reviews, dbeam+watch-polymer_chromium.org, michaelpg+watch-polymer_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix Polymer's Chrome-specific patch 1) Remove custom properties hunk -> it's no longer hit because we're using native custom properties 2) Add our paper-icon-button-light patch to customize the ripple[1] -> Upstream here: https://github.com/PolymerElements/paper-icon-button/pull/102 TBR=dpapad@chromium.org BUG=none Committed: https://crrev.com/2b117ab41806d678726ac89194d304d2ce050ff5 Cr-Commit-Position: refs/heads/master@{#424762}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -15 lines) Patch
M third_party/polymer/v1_0/chromium.patch View 1 chunk +15 lines, -14 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/polymer/polymer-extracted.js View 1 chunk +2 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 14 (6 generated)
Dan Beam
4 years, 2 months ago (2016-10-12 05:03:33 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2407243004/1
4 years, 2 months ago (2016-10-12 05:03:58 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/84846)
4 years, 2 months ago (2016-10-12 05:12:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2407243004/1
4 years, 2 months ago (2016-10-12 05:13:12 UTC) #7
commit-bot: I haz the power
Exceeded global retry quota
4 years, 2 months ago (2016-10-12 05:19:22 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2407243004/1
4 years, 2 months ago (2016-10-12 16:29:00 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-12 16:34:51 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-10-12 16:37:14 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2b117ab41806d678726ac89194d304d2ce050ff5
Cr-Commit-Position: refs/heads/master@{#424762}

Powered by Google App Engine
This is Rietveld 408576698