|
|
DescriptionRevert of Use per-frame task runner in XHR (patchset #5 id:80001 of https://codereview.chromium.org/2269513002/ )
Reason for revert:
Speculative revert for http://crbug.com/645365. Will reland once it turns out being not the case.
Original issue's description:
> Use per-frame task runner in XHR
>
> The XHR spec describes progress events on XHR are queued on the networking
> task source, where Networking task runner is the corresponding task runner.
> https://xhr.spec.whatwg.org/#dom-xmlhttprequest-send
>
> BUG=624696
>
> Committed: https://crrev.com/f884e370f225e3cb7cde91f08dcc369952c7b863
> Cr-Commit-Position: refs/heads/master@{#417230}
TBR=haraken@chromium.org,skyostil@chromium.org,alexclarke@chromium.org,dcheng@chromium.org,yhirano@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=624696, 645365
Committed: https://crrev.com/9262bc8c2325f8bc299935df41d53e1725a91f07
Cr-Commit-Position: refs/heads/master@{#424985}
Patch Set 1 #Patch Set 2 : rebase #Messages
Total messages: 18 (9 generated)
The CQ bit was checked by tzik@chromium.org
Created Revert of Use per-frame task runner in XHR
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Failed to apply patch for third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequestProgressEventThrottle.cpp: While running git apply --index -3 -p1; error: patch failed: third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequestProgressEventThrottle.cpp:75 Falling back to three-way merge... Applied patch to 'third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequestProgressEventThrottle.cpp' with conflicts. U third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequestProgressEventThrottle.cpp Patch: third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequestProgressEventThrottle.cpp Index: third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequestProgressEventThrottle.cpp diff --git a/third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequestProgressEventThrottle.cpp b/third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequestProgressEventThrottle.cpp index 102b7c5db5c4d445627c61c85600b57be5a7fe32..9bfb0444231bbee6dabf724534e563861e2038a0 100644 --- a/third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequestProgressEventThrottle.cpp +++ b/third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequestProgressEventThrottle.cpp @@ -27,7 +27,6 @@ #include "core/xmlhttprequest/XMLHttpRequestProgressEventThrottle.h" #include "core/EventTypeNames.h" -#include "core/dom/TaskRunnerHelper.h" #include "core/events/ProgressEvent.h" #include "core/inspector/InspectorInstrumentation.h" #include "core/inspector/InspectorTraceEvents.h" @@ -75,7 +74,7 @@ } XMLHttpRequestProgressEventThrottle::XMLHttpRequestProgressEventThrottle(XMLHttpRequest* target) - : TimerBase(TaskRunnerHelper::get(TaskType::Networking, target->getExecutionContext())) + : TimerBase(Platform::current()->currentThread()->scheduler()->timerTaskRunner()) , m_target(target) , m_hasDispatchedProgressProgressEvent(false) {
LGTM to revert
The CQ bit was checked by tzik@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Failed to apply patch for third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequestProgressEventThrottle.cpp: While running git apply --index -3 -p1; error: patch failed: third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequestProgressEventThrottle.cpp:75 Falling back to three-way merge... Applied patch to 'third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequestProgressEventThrottle.cpp' with conflicts. U third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequestProgressEventThrottle.cpp Patch: third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequestProgressEventThrottle.cpp Index: third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequestProgressEventThrottle.cpp diff --git a/third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequestProgressEventThrottle.cpp b/third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequestProgressEventThrottle.cpp index 102b7c5db5c4d445627c61c85600b57be5a7fe32..9bfb0444231bbee6dabf724534e563861e2038a0 100644 --- a/third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequestProgressEventThrottle.cpp +++ b/third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequestProgressEventThrottle.cpp @@ -27,7 +27,6 @@ #include "core/xmlhttprequest/XMLHttpRequestProgressEventThrottle.h" #include "core/EventTypeNames.h" -#include "core/dom/TaskRunnerHelper.h" #include "core/events/ProgressEvent.h" #include "core/inspector/InspectorInstrumentation.h" #include "core/inspector/InspectorTraceEvents.h" @@ -75,7 +74,7 @@ } XMLHttpRequestProgressEventThrottle::XMLHttpRequestProgressEventThrottle(XMLHttpRequest* target) - : TimerBase(TaskRunnerHelper::get(TaskType::Networking, target->getExecutionContext())) + : TimerBase(Platform::current()->currentThread()->scheduler()->timerTaskRunner()) , m_target(target) , m_hasDispatchedProgressProgressEvent(false) {
Description was changed from ========== Revert of Use per-frame task runner in XHR (patchset #5 id:80001 of https://codereview.chromium.org/2269513002/ ) Reason for revert: Speculative revert for http://crbug.com/645365. Will reland once it turns out being not the case. Original issue's description: > Use per-frame task runner in XHR > > The XHR spec describes progress events on XHR are queued on the networking > task source, where Networking task runner is the corresponding task runner. > https://xhr.spec.whatwg.org/#dom-xmlhttprequest-send > > BUG=624696 > > Committed: https://crrev.com/f884e370f225e3cb7cde91f08dcc369952c7b863 > Cr-Commit-Position: refs/heads/master@{#417230} TBR=haraken@chromium.org,skyostil@chromium.org,alexclarke@chromium.org,dcheng... # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=624696 ========== to ========== Revert of Use per-frame task runner in XHR (patchset #5 id:80001 of https://codereview.chromium.org/2269513002/ ) Reason for revert: Speculative revert for http://crbug.com/645365. Will reland once it turns out being not the case. Original issue's description: > Use per-frame task runner in XHR > > The XHR spec describes progress events on XHR are queued on the networking > task source, where Networking task runner is the corresponding task runner. > https://xhr.spec.whatwg.org/#dom-xmlhttprequest-send > > BUG=624696 > > Committed: https://crrev.com/f884e370f225e3cb7cde91f08dcc369952c7b863 > Cr-Commit-Position: refs/heads/master@{#417230} TBR=haraken@chromium.org,skyostil@chromium.org,alexclarke@chromium.org,dcheng... # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=624696, 645365 ==========
The CQ bit was checked by tzik@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org Link to the patchset: https://codereview.chromium.org/2407233002/#ps40001 (title: "rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Revert of Use per-frame task runner in XHR (patchset #5 id:80001 of https://codereview.chromium.org/2269513002/ ) Reason for revert: Speculative revert for http://crbug.com/645365. Will reland once it turns out being not the case. Original issue's description: > Use per-frame task runner in XHR > > The XHR spec describes progress events on XHR are queued on the networking > task source, where Networking task runner is the corresponding task runner. > https://xhr.spec.whatwg.org/#dom-xmlhttprequest-send > > BUG=624696 > > Committed: https://crrev.com/f884e370f225e3cb7cde91f08dcc369952c7b863 > Cr-Commit-Position: refs/heads/master@{#417230} TBR=haraken@chromium.org,skyostil@chromium.org,alexclarke@chromium.org,dcheng... # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=624696, 645365 ========== to ========== Revert of Use per-frame task runner in XHR (patchset #5 id:80001 of https://codereview.chromium.org/2269513002/ ) Reason for revert: Speculative revert for http://crbug.com/645365. Will reland once it turns out being not the case. Original issue's description: > Use per-frame task runner in XHR > > The XHR spec describes progress events on XHR are queued on the networking > task source, where Networking task runner is the corresponding task runner. > https://xhr.spec.whatwg.org/#dom-xmlhttprequest-send > > BUG=624696 > > Committed: https://crrev.com/f884e370f225e3cb7cde91f08dcc369952c7b863 > Cr-Commit-Position: refs/heads/master@{#417230} TBR=haraken@chromium.org,skyostil@chromium.org,alexclarke@chromium.org,dcheng... # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=624696, 645365 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Revert of Use per-frame task runner in XHR (patchset #5 id:80001 of https://codereview.chromium.org/2269513002/ ) Reason for revert: Speculative revert for http://crbug.com/645365. Will reland once it turns out being not the case. Original issue's description: > Use per-frame task runner in XHR > > The XHR spec describes progress events on XHR are queued on the networking > task source, where Networking task runner is the corresponding task runner. > https://xhr.spec.whatwg.org/#dom-xmlhttprequest-send > > BUG=624696 > > Committed: https://crrev.com/f884e370f225e3cb7cde91f08dcc369952c7b863 > Cr-Commit-Position: refs/heads/master@{#417230} TBR=haraken@chromium.org,skyostil@chromium.org,alexclarke@chromium.org,dcheng... # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=624696, 645365 ========== to ========== Revert of Use per-frame task runner in XHR (patchset #5 id:80001 of https://codereview.chromium.org/2269513002/ ) Reason for revert: Speculative revert for http://crbug.com/645365. Will reland once it turns out being not the case. Original issue's description: > Use per-frame task runner in XHR > > The XHR spec describes progress events on XHR are queued on the networking > task source, where Networking task runner is the corresponding task runner. > https://xhr.spec.whatwg.org/#dom-xmlhttprequest-send > > BUG=624696 > > Committed: https://crrev.com/f884e370f225e3cb7cde91f08dcc369952c7b863 > Cr-Commit-Position: refs/heads/master@{#417230} TBR=haraken@chromium.org,skyostil@chromium.org,alexclarke@chromium.org,dcheng... # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=624696, 645365 Committed: https://crrev.com/9262bc8c2325f8bc299935df41d53e1725a91f07 Cr-Commit-Position: refs/heads/master@{#424985} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/9262bc8c2325f8bc299935df41d53e1725a91f07 Cr-Commit-Position: refs/heads/master@{#424985} |