Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(722)

Issue 2407233002: Revert of Use per-frame task runner in XHR (Closed)

Created:
4 years, 2 months ago by tzik
Modified:
4 years, 2 months ago
CC:
chromium-reviews, blink-reviews, tyoshino+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Use per-frame task runner in XHR (patchset #5 id:80001 of https://codereview.chromium.org/2269513002/ ) Reason for revert: Speculative revert for http://crbug.com/645365. Will reland once it turns out being not the case. Original issue's description: > Use per-frame task runner in XHR > > The XHR spec describes progress events on XHR are queued on the networking > task source, where Networking task runner is the corresponding task runner. > https://xhr.spec.whatwg.org/#dom-xmlhttprequest-send > > BUG=624696 > > Committed: https://crrev.com/f884e370f225e3cb7cde91f08dcc369952c7b863 > Cr-Commit-Position: refs/heads/master@{#417230} TBR=haraken@chromium.org,skyostil@chromium.org,alexclarke@chromium.org,dcheng@chromium.org,yhirano@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=624696, 645365 Committed: https://crrev.com/9262bc8c2325f8bc299935df41d53e1725a91f07 Cr-Commit-Position: refs/heads/master@{#424985}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequestProgressEventThrottle.cpp View 1 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 18 (9 generated)
tzik
Created Revert of Use per-frame task runner in XHR
4 years, 2 months ago (2016-10-11 13:31:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2407233002/1
4 years, 2 months ago (2016-10-11 13:31:32 UTC) #3
commit-bot: I haz the power
Failed to apply patch for third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequestProgressEventThrottle.cpp: While running git apply --index -3 -p1; error: patch ...
4 years, 2 months ago (2016-10-11 14:34:39 UTC) #5
haraken
LGTM to revert
4 years, 2 months ago (2016-10-11 14:43:18 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2407233002/1
4 years, 2 months ago (2016-10-12 03:37:56 UTC) #8
commit-bot: I haz the power
Failed to apply patch for third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequestProgressEventThrottle.cpp: While running git apply --index -3 -p1; error: patch ...
4 years, 2 months ago (2016-10-12 03:42:37 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2407233002/40001
4 years, 2 months ago (2016-10-13 07:40:39 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 2 months ago (2016-10-13 08:51:13 UTC) #16
commit-bot: I haz the power
4 years, 2 months ago (2016-10-13 08:53:33 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9262bc8c2325f8bc299935df41d53e1725a91f07
Cr-Commit-Position: refs/heads/master@{#424985}

Powered by Google App Engine
This is Rietveld 408576698