Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 24072016: Use Unique<Cell> and Unique<PropertyCell> in LoadGlobalCell and StoreGlobalCell. (Closed)

Created:
7 years, 3 months ago by titzer
Modified:
7 years, 3 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Visibility:
Public.

Description

Use Unique<Cell> and Unique<PropertyCell> in LoadGlobalCell and StoreGlobalCell. BUG= R=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16865

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -27 lines) Patch
M src/arm/lithium-codegen-arm.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/hydrogen-instructions.h View 5 chunks +13 lines, -11 lines 0 comments Download
M src/hydrogen-instructions.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/mips/lithium-codegen-mips.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/unique.h View 1 chunk +6 lines, -6 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
titzer
Because.
7 years, 3 months ago (2013-09-20 11:56:23 UTC) #1
Toon Verwaest
lgtm
7 years, 3 months ago (2013-09-20 12:11:17 UTC) #2
titzer
7 years, 3 months ago (2013-09-20 12:32:42 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r16865 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698