src/ia32/macro-assembler-ia32.cc - Issue 24072013: Hydrogenisation of binops

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ia32/macro-assembler-ia32.cc

Issue 24072013: Hydrogenisation of binops (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: fix overwrite mode & better result typefeedback Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ia32/macro-assembler-ia32.cc

diff --git a/src/ia32/macro-assembler-ia32.cc b/src/ia32/macro-assembler-ia32.cc

index 5d25695f2db2c58781c16d18fc095590355b4d23..3fa02c27f81aa71a19338a2ef0d2181df492eecb 100644

--- a/src/ia32/macro-assembler-ia32.cc

+++ b/src/ia32/macro-assembler-ia32.cc

@@ -253,8 +253,8 @@ void MacroAssembler::X87TOSToI(Register result_reg,

Label::Distance dst) {

Label done;

sub(esp, Immediate(kPointerSize));

- fist_s(MemOperand(esp, 0));

fld(0);

+ fist_s(MemOperand(esp, 0));

fild_s(MemOperand(esp, 0));

pop(result_reg);

FCmp();

@@ -453,6 +453,7 @@ static double kUint32Bias =

void MacroAssembler::LoadUint32(XMMRegister dst,

XMMRegister scratch) {

+ ASSERT(!Serializer::enabled());

Label done;

cmp(src, Immediate(0));

movdbl(scratch,