remoting/android/java/src/org/chromium/chromoting/DesktopView.java - Issue 24072012: Hold video frame in Bitmap instead of keeping a ByteBuffer reference.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: remoting/android/java/src/org/chromium/chromoting/DesktopView.java

Issue 24072012: Hold video frame in Bitmap instead of keeping a ByteBuffer reference. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Keep track of buffers in JniFrameConsumer Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: remoting/android/java/src/org/chromium/chromoting/DesktopView.java

diff --git a/remoting/android/java/src/org/chromium/chromoting/DesktopView.java b/remoting/android/java/src/org/chromium/chromoting/DesktopView.java

index 2a4a994424588d789217ecef8a25f03b24fed4db..8209d287361971c1128247f9605912490cc1d46f 100644

--- a/remoting/android/java/src/org/chromium/chromoting/DesktopView.java

+++ b/remoting/android/java/src/org/chromium/chromoting/DesktopView.java

@@ -128,7 +128,7 @@ public class DesktopView extends SurfaceView implements Runnable, SurfaceHolder.

Log.w("deskview", "Canvas being redrawn on UI thread");

}

- Bitmap image = JniInterface.retrieveVideoFrame();

+ Bitmap image = JniInterface.getVideoFrame();

Canvas canvas = getHolder().lockCanvas();

synchronized (mTransform) {

canvas.setMatrix(mTransform);

« no previous file with comments | « no previous file | remoting/android/java/src/org/chromium/chromoting/jni/JniInterface.java » ('j') | no next file with comments »