Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(879)

Unified Diff: remoting/client/jni/chromoting_jni_runtime.h

Issue 24072012: Hold video frame in Bitmap instead of keeping a ByteBuffer reference. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/client/jni/chromoting_jni_runtime.h
diff --git a/remoting/client/jni/chromoting_jni_runtime.h b/remoting/client/jni/chromoting_jni_runtime.h
index bfe85492a6b62e995f80d418d9523ebde6d1bb17..831addc7a237830d71f1d6522abe5e5f4340f48e 100644
--- a/remoting/client/jni/chromoting_jni_runtime.h
+++ b/remoting/client/jni/chromoting_jni_runtime.h
@@ -79,8 +79,10 @@ class ChromotingJniRuntime {
const std::string& id,
const std::string& secret);
- // Updates image dimensions and canvas memory space. Call on display thread.
- void UpdateImageBuffer(int width, int height, jobject buffer);
+ // Updates the video image buffer, copying pixels from |buffer| into a Java
+ // Bitmap object. |buffer| is owned by the caller, and may be freed after this
+ // function returns. Call on the display thread.
+ void UpdateImageBuffer(int width, int height, uint8* buffer);
Sergey Ulanov 2013/09/25 23:32:08 Pass the frame as webrtc::DesktopFrame reference.
// Updates cursor shape. Call on display thread.
void UpdateCursorShape(const protocol::CursorShapeInfo& cursor_shape);

Powered by Google App Engine
This is Rietveld 408576698