Hold video frame in Bitmap instead of keeping a ByteBuffer reference.

remoting/client/jni/chromoting_jni_runtime.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef REMOTING_CLIENT_JNI_CHROMOTING_JNI_RUNTIME_H_
 #define REMOTING_CLIENT_JNI_CHROMOTING_JNI_RUNTIME_H_
 
 #include <jni.h>
 #include <string>
 
+#include "base/android/scoped_java_ref.h"
 #include "base/at_exit.h"
 #include "net/url_request/url_request_context_getter.h"
 #include "remoting/base/auto_thread.h"
 #include "remoting/client/jni/chromoting_jni_instance.h"
 #include "remoting/protocol/connection_to_host.h"
 
 template<typename T> struct DefaultSingletonTraits;
 
+namespace webrtc {
+class DesktopFrame;

[Sergey Ulanov, 2013/10/08 22:15:02]

Not used in this file.

[Lambros, 2013/10/10 01:35:58]

Removed.

+}  // namespace webrtc
+
 namespace remoting {
 
 // Houses the global resources on which the Chromoting components run
 // (e.g. message loops and task runners). Proxies outgoing JNI calls from its
 // ChromotingJniInstance member to Java. All its methods should be invoked
 // exclusively from the UI thread unless otherwise noted.
 class ChromotingJniRuntime {
  public:
   // This class is instantiated at process initialization and persists until
   // we close. Its components are reused across |ChromotingJniInstance|s.
@@ skipping 43 matching lines @@
                               protocol::ErrorCode error);
 
   // Pops up a dialog box asking the user to enter a PIN. Call on UI thread.
   void DisplayAuthenticationPrompt(bool pairing_supported);
 
   // Saves new pairing credentials to permanent storage. Call on UI thread.
   void CommitPairingCredentials(const std::string& host,
                                 const std::string& id,
                                 const std::string& secret);
 
-  // Updates image dimensions and canvas memory space. Call on display thread.
-  void UpdateImageBuffer(int width, int height, jobject buffer);
+  // Creates a new Bitmap object to store a video frame.
+  base::android::ScopedJavaLocalRef<jobject> NewBitmap(
+      webrtc::DesktopSize size);
+
+  // Updates video frame bitmap. Call on the display thread.
+  void UpdateFrameBitmap(jobject bitmap);

[Sergey Ulanov, 2013/10/08 22:15:02]

please comment that |bitmat| must be an android.graphics.Bitmap.

[Lambros, 2013/10/10 01:35:58]

Done.

 
   // Updates cursor shape. Call on display thread.
   void UpdateCursorShape(const protocol::CursorShapeInfo& cursor_shape);
 
   // Draws the latest image buffer onto the canvas. Call on the display thread.
   void RedrawCanvas();
 
  private:
   ChromotingJniRuntime();
 
@@ skipping 28 matching lines @@
   scoped_refptr<ChromotingJniInstance> session_;
 
   friend struct DefaultSingletonTraits<ChromotingJniRuntime>;
 
   DISALLOW_COPY_AND_ASSIGN(ChromotingJniRuntime);
 };
 
 }  // namespace remoting
 
 #endif