Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 2407183003: Revert of Enable saving the same file in multiple archives (Closed)

Created:
4 years, 2 months ago by alph
Modified:
4 years, 2 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Revert of Enable saving the same file in multiple archives (patchset #3 id:40001 of https://codereview.chromium.org/2402423002/ ) Reason for revert: Broke the archive build step https://build.chromium.org/p/chromium/builders/Linux%20x64/builds/26845 Original issue's description: > Enable saving the same file in multiple archives > > Earlier I submitted a CL to archive content shell and I ran into an issue > where the current FILES.cfg parser doesn't allow listing the same file > for multiple archives. > > I opted to allow multiple entries of the same file in FILES.cfg rather than > making the 'archive' property a list because this allows more configurability > (e.g. for icudtl.dat, we only need to archive it for content shell for dev builds > but for the main archive we archive it for dev and official builds). > > BUG=654486 > > Committed: https://chromium.googlesource.com/chromium/tools/build/+/47c03a95aef64407f6d9bb5db7509bdca9be47f4 TBR=mmoss@chromium.org,kerz@chromium.org,chenwilliam@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=654486

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -55 lines) Patch
M scripts/common/archive_utils.py View 3 chunks +16 lines, -21 lines 0 comments Download
M scripts/common/archive_utils_unittest.py View 4 chunks +5 lines, -34 lines 0 comments Download

Messages

Total messages: 22 (10 generated)
alph
Created Revert of Enable saving the same file in multiple archives
4 years, 2 months ago (2016-10-11 22:02:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2407183003/1
4 years, 2 months ago (2016-10-11 22:02:30 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 2 months ago (2016-10-11 22:02:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2407183003/1
4 years, 2 months ago (2016-10-11 22:09:30 UTC) #7
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 2 months ago (2016-10-11 22:09:32 UTC) #9
chenwilliam
lgtm lgtm
4 years, 2 months ago (2016-10-11 22:36:14 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2407183003/1
4 years, 2 months ago (2016-10-11 22:42:50 UTC) #12
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 2 months ago (2016-10-11 22:42:52 UTC) #14
caseq
rs lgtm
4 years, 2 months ago (2016-10-11 23:05:24 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2407183003/1
4 years, 2 months ago (2016-10-11 23:05:44 UTC) #18
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 2 months ago (2016-10-11 23:05:46 UTC) #20
alph
4 years, 2 months ago (2016-10-12 00:16:24 UTC) #21
Seems to be fixed already.

Powered by Google App Engine
This is Rietveld 408576698