[modules] Don't unnecessarily keep function alive after evaluation.

src/objects-debug.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/objects.h"
 
 #include "src/bootstrapper.h"
 #include "src/disasm.h"
 #include "src/disassembler.h"
 #include "src/field-type.h"
@@ skipping 925 matching lines @@
   CHECK(deferred()->IsJSObject() || deferred()->IsUndefined(isolate));
   CHECK(before_debug_event()->IsJSObject() ||
         before_debug_event()->IsUndefined(isolate));
   CHECK(after_debug_event()->IsJSObject() ||
         after_debug_event()->IsUndefined(isolate));
   CHECK(context()->IsContext());
 }
 
 void JSModuleNamespace::JSModuleNamespaceVerify() {
   CHECK(IsJSModuleNamespace());
-  module()->ObjectVerify();
+  VerifyPointer(module());
 }
 
 void JSFixedArrayIterator::JSFixedArrayIteratorVerify() {
   CHECK(IsJSFixedArrayIterator());
 
-  CHECK(array()->IsFixedArray());
+  VerifyPointer(array());
+  VerifyPointer(initial_next());
   VerifySmiField(kIndexOffset);
-  CHECK(initial_next()->IsJSFunction());
 
   CHECK_LE(index(), array()->length());
 }
 
 void Module::ModuleVerify() {
-  Isolate* isolate = GetIsolate();
   CHECK(IsModule());
-  CHECK(code()->IsSharedFunctionInfo() || code()->IsJSFunction());
-  code()->ObjectVerify();
-  exports()->ObjectVerify();
-  requested_modules()->ObjectVerify();
-  VerifySmiField(kFlagsOffset);
+
+  VerifyPointer(code());
+  VerifyPointer(exports());
+  VerifyPointer(module_namespace());
+  VerifyPointer(requested_modules());
   VerifySmiField(kHashOffset);
-  CHECK(module_namespace()->IsUndefined(isolate) ||
+
+  CHECK((!instantiated() && code()->IsSharedFunctionInfo()) ||
+        (instantiated() && !evaluated() && code()->IsJSFunction()) ||
+        (instantiated() && evaluated() && code()->IsModuleInfo()));
+
+  CHECK(module_namespace()->IsUndefined(GetIsolate()) ||
         module_namespace()->IsJSModuleNamespace());
+
   // TODO(neis): Check more.
 }
 
 void PrototypeInfo::PrototypeInfoVerify() {
   CHECK(IsPrototypeInfo());
   if (prototype_users()->IsWeakFixedArray()) {
     WeakFixedArray::cast(prototype_users())->FixedArrayVerify();
   } else {
     CHECK(prototype_users()->IsSmi());
   }
@@ skipping 428 matching lines @@
 
   // Both are done at the same time.
   CHECK_EQ(new_it.done(), old_it.done());
 }
 
 
 #endif  // DEBUG
 
 }  // namespace internal
 }  // namespace v8