[modules] Don't unnecessarily keep function alive after evaluation.

src/objects-inl.h

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // Review notes:
 //
 // - The use of macros in these inline functions may seem superfluous
 // but it is absolutely needed to make sure gcc generates optimal
 // code. gcc is not happy when attempting to inline too deep.
 //
@@ skipping 5695 matching lines @@
 
 ACCESSORS(ContextExtension, scope_info, ScopeInfo, kScopeInfoOffset)
 ACCESSORS(ContextExtension, extension, Object, kExtensionOffset)
 
 ACCESSORS(JSModuleNamespace, module, Module, kModuleOffset)
 
 ACCESSORS(Module, code, Object, kCodeOffset)
 ACCESSORS(Module, exports, ObjectHashTable, kExportsOffset)
 ACCESSORS(Module, module_namespace, HeapObject, kModuleNamespaceOffset)
 ACCESSORS(Module, requested_modules, FixedArray, kRequestedModulesOffset)
-SMI_ACCESSORS(Module, flags, kFlagsOffset)
-BOOL_ACCESSORS(Module, flags, evaluated, kEvaluatedBit)
 ACCESSORS(Module, embedder_data, Object, kEmbedderDataOffset)
 SMI_ACCESSORS(Module, hash, kHashOffset)
 
 SharedFunctionInfo* Module::shared() const {
+  DCHECK(!evaluated());

[adamk, 2016/10/11 15:54:05]

I think I'd prefer killing this method and inlining any callers than leaving it
here, it seems dangerous now.

   return code()->IsSharedFunctionInfo() ? SharedFunctionInfo::cast(code())
                                         : JSFunction::cast(code())->shared();
 }
 
+bool Module::evaluated() const { return code()->IsModuleInfo(); }
+
+void Module::set_evaluated() {
+  DCHECK(!evaluated());
+  return set_code(shared()->scope_info()->ModuleDescriptorInfo());
+}
+
+bool Module::instantiated() const { return !code()->IsSharedFunctionInfo(); }
+
 ModuleInfo* Module::info() const {
+  if (evaluated()) return ModuleInfo::cast(code());
   return shared()->scope_info()->ModuleDescriptorInfo();
 }
 
 ACCESSORS(AccessorPair, getter, Object, kGetterOffset)
 ACCESSORS(AccessorPair, setter, Object, kSetterOffset)
 
 ACCESSORS(AccessCheckInfo, callback, Object, kCallbackOffset)
 ACCESSORS(AccessCheckInfo, named_interceptor, Object, kNamedInterceptorOffset)
 ACCESSORS(AccessCheckInfo, indexed_interceptor, Object,
           kIndexedInterceptorOffset)
@@ skipping 2589 matching lines @@
 #undef WRITE_INT64_FIELD
 #undef READ_BYTE_FIELD
 #undef WRITE_BYTE_FIELD
 #undef NOBARRIER_READ_BYTE_FIELD
 #undef NOBARRIER_WRITE_BYTE_FIELD
 
 }  // namespace internal
 }  // namespace v8
 
 #endif  // V8_OBJECTS_INL_H_