Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 2407163005: Partial sync of device_management_backened.proto with server version. (Closed)

Created:
4 years, 2 months ago by Thiemo Nagel
Modified:
4 years, 2 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Partial sync of device_management_backened.proto with server version. Client and server are still not fully aligned, but getting closer... BUG=645078 Committed: https://crrev.com/1f15e4cc046f62b1332076dc834e201d697ecc58 Cr-Commit-Position: refs/heads/master@{#425003}

Patch Set 1 #

Patch Set 2 : Rebase. #

Patch Set 3 : Update DeviceMode. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -15 lines) Patch
M components/policy/core/common/cloud/cloud_policy_client.cc View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M components/policy/proto/device_management_backend.proto View 1 11 chunks +93 lines, -15 lines 1 comment Download

Messages

Total messages: 19 (14 generated)
Thiemo Nagel
Hi Roman, could you please take a look? Thank you! Thiemo https://codereview.chromium.org/2407163005/diff/40001/components/policy/proto/device_management_backend.proto File components/policy/proto/device_management_backend.proto (right): ...
4 years, 2 months ago (2016-10-13 10:45:30 UTC) #10
Roman Sorokin (ftl)
AD changes lgtm
4 years, 2 months ago (2016-10-13 11:29:37 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2407163005/40001
4 years, 2 months ago (2016-10-13 11:39:08 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-10-13 11:44:09 UTC) #17
commit-bot: I haz the power
4 years, 2 months ago (2016-10-13 11:46:52 UTC) #19
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/1f15e4cc046f62b1332076dc834e201d697ecc58
Cr-Commit-Position: refs/heads/master@{#425003}

Powered by Google App Engine
This is Rietveld 408576698