Delete TestDisplaySnapshot and update tests.

Delete TestDisplaySnapshot and update tests.

Replace TestDisplaySnapshot with FakeDisplaySnapshot in tests.
FakeDisplaySnapshot has builder that makes it more readable. Delete an
unncessary build target along with TestDisplaySnapshot.

Tests should be unchanged for the most part. One test was split into two
tests where two very different behaviours were being checked.

Also update tests to use C++11 features where possible. Mostly replacing
raw pointers with unique_ptr<> and NULL with nullptr.

BUG=none

Committed: https://crrev.com/c354dd23b3dba31cd144ffa04e072fe330acc7c3
Cr-Commit-Position: refs/heads/master@{#427147}

[kylechar, 2016-10-13 19:57:03]

The CQ bit was checked by kylechar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-13 19:57:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-13 20:54:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-13 20:54:42]

Dry run: This issue passed the CQ dry run.

[kylechar, 2016-10-21 14:42:10]

The CQ bit was checked by kylechar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-21 14:42:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kylechar, 2016-10-21 14:45:47]

Description was changed from

==========
Delete TestDisplaySnapshot and update tests.

Replace TestDisplaySnapshot with FakeDisplaySnapshot. Use builder where
possible to improve readability.

Update tests to use C++11 features where possible.

BUG=none
==========

to

==========
Delete TestDisplaySnapshot and update tests.

Replace TestDisplaySnapshot with FakeDisplaySnapshot in tests.
FakeDisplaySnapshot has builder that makes it more readable. Delete an
unncessary build target along with TestDisplaySnapshot.

Tests should be unchanged for the most part. One test was split into two
tests where two very different behaviours were being checked.

Also update tests to use C++11 features where possible. Mostly replacing
raw pointers with unique_ptr<> and NULL with nullptr.

BUG=none
==========

[commit-bot: I haz the power, 2016-10-21 15:46:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-21 15:46:23]

Dry run: This issue passed the CQ dry run.

[kylechar, 2016-10-21 16:11:24]

kylechar@chromium.org changed reviewers:
+ oshima@chromium.org

[oshima, 2016-10-24 18:29:48]

lgtm

[kylechar, 2016-10-24 18:35:18]

The CQ bit was checked by kylechar@chromium.org

[commit-bot: I haz the power, 2016-10-24 18:35:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-24 21:04:18]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-24 21:06:51]

Description was changed from

==========
Delete TestDisplaySnapshot and update tests.

Replace TestDisplaySnapshot with FakeDisplaySnapshot in tests.
FakeDisplaySnapshot has builder that makes it more readable. Delete an
unncessary build target along with TestDisplaySnapshot.

Tests should be unchanged for the most part. One test was split into two
tests where two very different behaviours were being checked.

Also update tests to use C++11 features where possible. Mostly replacing
raw pointers with unique_ptr<> and NULL with nullptr.

BUG=none
==========

to

==========
Delete TestDisplaySnapshot and update tests.

Replace TestDisplaySnapshot with FakeDisplaySnapshot in tests.
FakeDisplaySnapshot has builder that makes it more readable. Delete an
unncessary build target along with TestDisplaySnapshot.

Tests should be unchanged for the most part. One test was split into two
tests where two very different behaviours were being checked.

Also update tests to use C++11 features where possible. Mostly replacing
raw pointers with unique_ptr<> and NULL with nullptr.

BUG=none

Committed: https://crrev.com/c354dd23b3dba31cd144ffa04e072fe330acc7c3
Cr-Commit-Position: refs/heads/master@{#427147}
==========

[commit-bot: I haz the power, 2016-10-24 21:06:52]

Patchset 3 (id:??) landed as
https://crrev.com/c354dd23b3dba31cd144ffa04e072fe330acc7c3
Cr-Commit-Position: refs/heads/master@{#427147}