Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(487)

Issue 2407153007: [turbofan] Remove Float32 truncation. (Closed)

Created:
4 years, 2 months ago by mvstanton
Modified:
4 years, 2 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Remove Float32 truncation. R=jarin@chromium.org BUG= Committed: https://crrev.com/26307c76c3193275e387a142b5d49ae7620e2e91 Cr-Commit-Position: refs/heads/master@{#40266}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -19 lines) Patch
M src/compiler/representation-change.h View 3 chunks +2 lines, -4 lines 2 comments Download
M src/compiler/representation-change.cc View 3 chunks +9 lines, -14 lines 0 comments Download
M src/compiler/simplified-lowering.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (6 generated)
mvstanton
Hi Jaro, Does it make sense to return a non-truncating Float32 UseInfo? Thanks for the ...
4 years, 2 months ago (2016-10-12 14:09:37 UTC) #3
Jarin
lgtm https://codereview.chromium.org/2407153007/diff/1/src/compiler/representation-change.h File src/compiler/representation-change.h (right): https://codereview.chromium.org/2407153007/diff/1/src/compiler/representation-change.h#newcode136 src/compiler/representation-change.h:136: return UseInfo(MachineRepresentation::kFloat32, Truncation::Any()); It might be better to ...
4 years, 2 months ago (2016-10-12 18:04:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2407153007/1
4 years, 2 months ago (2016-10-13 13:25:44 UTC) #8
mvstanton
Thanks Jaro, landing... https://codereview.chromium.org/2407153007/diff/1/src/compiler/representation-change.h File src/compiler/representation-change.h (right): https://codereview.chromium.org/2407153007/diff/1/src/compiler/representation-change.h#newcode136 src/compiler/representation-change.h:136: return UseInfo(MachineRepresentation::kFloat32, Truncation::Any()); On 2016/10/12 18:04:01, ...
4 years, 2 months ago (2016-10-13 13:25:48 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-13 13:38:04 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-13 13:38:35 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/26307c76c3193275e387a142b5d49ae7620e2e91
Cr-Commit-Position: refs/heads/master@{#40266}

Powered by Google App Engine
This is Rietveld 408576698