Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(538)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2407153006: Milo: Add builder name to builder page (Closed)

Created:
4 years, 2 months ago by Ryan Tseng
Modified:
4 years, 1 month ago
Reviewers:
estaab, nodir, hinoka
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, andrew.wang, todd, tandrii+luci-go_chromium.org, M-A Ruel
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+278 lines, -267 lines) Patch
M milo/api/proto/pb.discovery.go View 1 chunk +269 lines, -266 lines 1 comment Download
M milo/appengine/buildbot/builder.go View 1 chunk +3 lines, -1 line 0 comments Download
M milo/appengine/frontend/expectations/buildbot-buildbot.TestableBuilder-Basic_Test_no_builds.html View 1 chunk +2 lines, -0 lines 0 comments Download
M milo/appengine/frontend/expectations/buildbot-buildbot.TestableBuilder-Basic_Test_with_builds.html View 1 chunk +2 lines, -0 lines 0 comments Download
M milo/appengine/frontend/templates/buildbot/pages/builder.html View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
hinoka
ptal https://codereview.chromium.org/2407153006/diff/1/milo/api/proto/pb.discovery.go File milo/api/proto/pb.discovery.go (right): https://codereview.chromium.org/2407153006/diff/1/milo/api/proto/pb.discovery.go#newcode1 milo/api/proto/pb.discovery.go:1: // AUTOGENERATED. DO NOT EDIT. Not sure why ...
4 years, 2 months ago (2016-10-12 04:45:57 UTC) #4
nodir
lgtm
4 years, 2 months ago (2016-10-12 06:43:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2407153006/1
4 years, 2 months ago (2016-10-17 22:10:52 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: Luci-go Win Tester on luci.infra.try (JOB_FAILED, https://luci-milo.appspot.com/swarming/task/31ed84350b770610)
4 years, 2 months ago (2016-10-18 00:13:40 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2407153006/1
4 years, 1 month ago (2016-10-27 02:31:35 UTC) #13
commit-bot: I haz the power
4 years, 1 month ago (2016-10-27 03:10:02 UTC) #15
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://github.com/luci/luci-go/commit/e06b753539544d8489fd2610bfc764e53d3813e2

Powered by Google App Engine
This is Rietveld 408576698