ui/views/cocoa/bridged_native_widget.mm - Issue 2407153004: MacViews: Don't set window's alpha to 0 if window is already visible.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/cocoa/bridged_native_widget.mm

Issue 2407153004: MacViews: Don't set window's alpha to 0 if window is already visible. (Closed)

Patch Set: Check window's visibility before setting alpha to 0 Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/views/cocoa/bridged_native_widget.mm

diff --git a/ui/views/cocoa/bridged_native_widget.mm b/ui/views/cocoa/bridged_native_widget.mm

index b0ab01429cdce334feb89a25766c3dd61b38532a..a39d0ec65ae10e6dba938923a4a74fba62ebbbbd 100644

--- a/ui/views/cocoa/bridged_native_widget.mm

+++ b/ui/views/cocoa/bridged_native_widget.mm

@@ -578,7 +578,7 @@ void BridgedNativeWidget::SetVisibilityState(WindowVisibilityState new_state) {

// mouse clicks till then.

// TODO(karandeepb): Investigate whether similar technique is needed for other

// dialog types.

- if (layer() && [window_ isOpaque] &&

+ if (layer() && [window_ isOpaque] && !window_visible_ &&

!native_widget_mac_->GetWidget()->IsModal()) {

initial_visibility_suppressed_ = true;

[window_ setAlphaValue:0.0];

« no previous file with comments | « no previous file | no next file » | no next file with comments »