Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2407153003: [runtime] Avoid code duplication in %CreateIterResultObject. (Closed)

Created:
4 years, 2 months ago by neis
Modified:
4 years, 2 months ago
Reviewers:
jgruber
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[runtime] Avoid code duplication in %CreateIterResultObject. R=jgruber@chromium.org BUG= Committed: https://crrev.com/d1d2addb19f1a648bc3a2c43c5a89e44d4a5cfd6 Cr-Commit-Position: refs/heads/master@{#40243}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -5 lines) Patch
M src/runtime/runtime-object.cc View 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
neis
4 years, 2 months ago (2016-10-11 14:49:24 UTC) #1
jgruber
lgtm
4 years, 2 months ago (2016-10-12 06:44:57 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2407153003/1
4 years, 2 months ago (2016-10-13 06:02:59 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-13 06:26:40 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-10-13 06:26:56 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d1d2addb19f1a648bc3a2c43c5a89e44d4a5cfd6
Cr-Commit-Position: refs/heads/master@{#40243}

Powered by Google App Engine
This is Rietveld 408576698