[heap] Use RAIL mode for initial heap sizing

[heap] Use RAIL mode for initial heap sizing

BUG=chromium:613518
Committed: https://crrev.com/aea4f1a704829fcb3fc3584b9d9948deeb5bcaa5
Cr-Commit-Position: refs/heads/master@{#41459}

[ulan, 2016-10-11 08:50:50]

ulan@chromium.org changed reviewers:
+ mlippautz@chromium.org

[ulan, 2016-10-11 08:50:50]

PTAL

[ulan, 2016-10-11 08:51:18]

It depends on https://codereview.chromium.org/2397753006/

[Hannes Payer (out of office), 2016-10-11 09:02:08]

hpayer@chromium.org changed reviewers:
+ hpayer@chromium.org

[Hannes Payer (out of office), 2016-10-11 09:02:09]

LGTM, only one comment about the heuristic.

https://codereview.chromium.org/2407153002/diff/40001/src/heap/heap.h
File src/heap/heap.h (right):

https://codereview.chromium.org/2407153002/diff/40001/src/heap/heap.h#newcode...
src/heap/heap.h:1813: static const int kMaxLoadTimeMs = 3000;
Why 3 seconds? Load was originally aiming for 1 second.

[ulan, 2016-10-11 10:37:49]

Description was changed from

==========
[heap] Use RAIL mode for initial heap sizing

BUG=
==========

to

==========
[heap] Use RAIL mode for initial heap sizing

BUG=chromium:613518
==========

[Michael Lippautz, 2016-10-12 18:40:30]

lgtm

[ulan, 2016-12-02 11:42:28]

The chrome CL landed. I am going to land this soon.

https://codereview.chromium.org/2407153002/diff/40001/src/heap/heap.h
File src/heap/heap.h (right):

https://codereview.chromium.org/2407153002/diff/40001/src/heap/heap.h#newcode...
src/heap/heap.h:1813: static const int kMaxLoadTimeMs = 3000;
On 2016/10/11 09:02:09, Hannes Payer wrote:
> Why 3 seconds? Load was originally aiming for 1 second.
The value is chosen as the largest load time observed in v8 browsing benchmarks.

[ulan, 2016-12-02 12:50:36]

The CQ bit was checked by ulan@chromium.org

[ulan, 2016-12-02 12:50:37]

The patchset sent to the CQ was uploaded after l-g-t-m from
mlippautz@chromium.org, hpayer@chromium.org
Link to the patchset: https://codereview.chromium.org/2407153002/#ps60001
(title: "rebase")

[commit-bot: I haz the power, 2016-12-02 12:50:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Hannes Payer (out of office), 2016-12-02 12:50:56]

LGTM

[ulan, 2016-12-02 12:50:56]

The CQ bit was unchecked by ulan@chromium.org

[ulan, 2016-12-02 15:17:18]

The CQ bit was checked by ulan@chromium.org

[ulan, 2016-12-02 15:17:18]

The patchset sent to the CQ was uploaded after l-g-t-m from
mlippautz@chromium.org, hpayer@chromium.org
Link to the patchset: https://codereview.chromium.org/2407153002/#ps100001
(title: "fix test")

[commit-bot: I haz the power, 2016-12-02 15:17:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-02 15:38:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-02 15:38:25]

Try jobs failed on following builders:
  v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/13604)
  v8_mac_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng_triggered/bui...)

[ulan, 2016-12-02 16:08:41]

The CQ bit was checked by ulan@chromium.org

[ulan, 2016-12-02 16:08:41]

The patchset sent to the CQ was uploaded after l-g-t-m from
mlippautz@chromium.org, hpayer@chromium.org
Link to the patchset: https://codereview.chromium.org/2407153002/#ps120001
(title: "fix test")

[commit-bot: I haz the power, 2016-12-02 16:08:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-02 16:33:46]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1480694921276840,
"parent_rev": "c6764004b0a2acda4282732fc2afe6f7ee8342c0", "commit_rev":
"7729d3cf1a836b0dce3ec143c6f94e4abc423dd1"}

[commit-bot: I haz the power, 2016-12-02 16:33:51]

Description was changed from

==========
[heap] Use RAIL mode for initial heap sizing

BUG=chromium:613518
==========

to

==========
[heap] Use RAIL mode for initial heap sizing

BUG=chromium:613518
==========

[commit-bot: I haz the power, 2016-12-02 16:33:52]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-12-02 16:34:19]

Description was changed from

==========
[heap] Use RAIL mode for initial heap sizing

BUG=chromium:613518
==========

to

==========
[heap] Use RAIL mode for initial heap sizing

BUG=chromium:613518

Committed: https://crrev.com/aea4f1a704829fcb3fc3584b9d9948deeb5bcaa5
Cr-Commit-Position: refs/heads/master@{#41459}
==========

[commit-bot: I haz the power, 2016-12-02 16:34:20]

Patchset 7 (id:??) landed as
https://crrev.com/aea4f1a704829fcb3fc3584b9d9948deeb5bcaa5
Cr-Commit-Position: refs/heads/master@{#41459}

[gsathya, 2016-12-03 01:30:19]

On 2016/12/02 16:34:20, commit-bot: I haz the power wrote:
> Patchset 7 (id:??) landed as
> https://crrev.com/aea4f1a704829fcb3fc3584b9d9948deeb5bcaa5
> Cr-Commit-Position: refs/heads/master@{#41459}

Ulan, this CL regresses the promises benchmark by 9%. See the second spike here
--
https://chromeperf.appspot.com/report?sid=a6397f62515bcf6553280211ef6af517b8c...