Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 2407133002: [regexp] Skip regexp-property-lu-ui test in gc-stress (Closed)

Created:
4 years, 2 months ago by jgruber
Modified:
4 years, 2 months ago
Reviewers:
Michael Achenbach
CC:
v8-reviews_googlegroups.com, Yang
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[regexp] Skip regexp-property-lu-ui test in gc-stress This test is timing out in gc-stress mode since RegExp.prototype.test was moved to C++. RE.proto.test will be improved shortly, and this test should be reenabled then. BUG=v8:5339 NOTRY=true Committed: https://crrev.com/effb8def76ac017c86b19d5ff4dc24f3d4c014cb Cr-Commit-Position: refs/heads/master@{#40150}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M test/mjsunit/mjsunit.status View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
jgruber
4 years, 2 months ago (2016-10-11 07:07:55 UTC) #4
Michael Achenbach
lgtm - for skipping tests you can also add NOTRY=true to the CL description. CQ ...
4 years, 2 months ago (2016-10-11 07:10:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2407133002/1
4 years, 2 months ago (2016-10-11 07:17:08 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-11 07:19:30 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-10-11 07:19:52 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/effb8def76ac017c86b19d5ff4dc24f3d4c014cb
Cr-Commit-Position: refs/heads/master@{#40150}

Powered by Google App Engine
This is Rietveld 408576698