Index: src/code-stubs.cc |
diff --git a/src/code-stubs.cc b/src/code-stubs.cc |
index 06b7afcaeb28cd90b182e374225ab9a66dfa030a..ee10aad8780b720e5c0d1a41f499c05040a627f3 100644 |
--- a/src/code-stubs.cc |
+++ b/src/code-stubs.cc |
@@ -1491,13 +1491,35 @@ compiler::Node* IncStub::Generate(CodeStubAssembler* assembler, |
assembler->Bind(&if_valuenotnumber); |
{ |
- // Convert to a Number first and try again. |
- Callable callable = |
- CodeFactory::NonNumberToNumber(assembler->isolate()); |
- var_type_feedback.Bind( |
- assembler->Int32Constant(BinaryOperationFeedback::kAny)); |
- value_var.Bind(assembler->CallStub(callable, context, value)); |
- assembler->Goto(&start); |
+ Label if_valueisoddball(assembler), if_valuenotoddball(assembler); |
+ Node* instance_type = assembler->LoadMapInstanceType(value_map); |
+ Node* is_oddball = assembler->Word32Equal( |
+ instance_type, assembler->Int32Constant(ODDBALL_TYPE)); |
+ assembler->Branch(is_oddball, &if_valueisoddball, &if_valuenotoddball); |
+ |
+ assembler->Bind(&if_valueisoddball); |
+ { |
+ // Convert Oddball to Number and check again. |
+ value_var.Bind( |
+ assembler->LoadObjectField(value, Oddball::kToNumberOffset)); |
+ // We do not require an Or with earlier feedback here because once we |
+ // convert the value to a number, we cannot reach this path. We can |
+ // only reach this path on the first pass. |
+ var_type_feedback.Bind(assembler->Int32Constant( |
+ BinaryOperationFeedback::kNumberOrOddball)); |
+ assembler->Goto(&start); |
+ } |
+ |
+ assembler->Bind(&if_valuenotoddball); |
+ { |
+ // Convert to a Number first and try again. |
+ Callable callable = |
+ CodeFactory::NonNumberToNumber(assembler->isolate()); |
+ var_type_feedback.Bind( |
+ assembler->Int32Constant(BinaryOperationFeedback::kAny)); |
+ value_var.Bind(assembler->CallStub(callable, context, value)); |
+ assembler->Goto(&start); |
+ } |
} |
} |
} |
@@ -1601,13 +1623,35 @@ compiler::Node* DecStub::Generate(CodeStubAssembler* assembler, |
assembler->Bind(&if_valuenotnumber); |
{ |
- // Convert to a Number first and try again. |
- Callable callable = |
- CodeFactory::NonNumberToNumber(assembler->isolate()); |
- var_type_feedback.Bind( |
- assembler->Int32Constant(BinaryOperationFeedback::kAny)); |
- value_var.Bind(assembler->CallStub(callable, context, value)); |
- assembler->Goto(&start); |
+ Label if_valueisoddball(assembler), if_valuenotoddball(assembler); |
+ Node* instance_type = assembler->LoadMapInstanceType(value_map); |
+ Node* is_oddball = assembler->Word32Equal( |
+ instance_type, assembler->Int32Constant(ODDBALL_TYPE)); |
+ assembler->Branch(is_oddball, &if_valueisoddball, &if_valuenotoddball); |
+ |
+ assembler->Bind(&if_valueisoddball); |
+ { |
+ // Convert Oddball to Number and check again. |
+ value_var.Bind( |
+ assembler->LoadObjectField(value, Oddball::kToNumberOffset)); |
+ // We do not require an Or with earlier feedback here because once we |
+ // convert the value to a number, we cannot reach this path. We can |
+ // only reach this path on the first pass. |
Leszek Swirski
2016/10/19 11:34:01
Can we add an assert that var_type_feedback is not
Leszek Swirski
2016/10/19 11:35:30
Um, by not bound I mean "value is 0" or something
mythria
2016/10/19 14:35:41
Great suggestion. I wanted to some kind of check b
|
+ var_type_feedback.Bind(assembler->Int32Constant( |
+ BinaryOperationFeedback::kNumberOrOddball)); |
+ assembler->Goto(&start); |
+ } |
+ |
+ assembler->Bind(&if_valuenotoddball); |
+ { |
+ // Convert to a Number first and try again. |
+ Callable callable = |
+ CodeFactory::NonNumberToNumber(assembler->isolate()); |
+ var_type_feedback.Bind( |
+ assembler->Int32Constant(BinaryOperationFeedback::kAny)); |
+ value_var.Bind(assembler->CallStub(callable, context, value)); |
+ assembler->Goto(&start); |
+ } |
} |
} |
} |