Issue 24071003: Add toSVGImage fuction, and use it as much as we can.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 24071003: Add toSVGImage fuction, and use it as much as we can. (Closed)

Created:
7 years, 3 months ago by gyuyoung-inactive

Modified:
7 years, 3 months ago

Reviewers:
tkent

CC:
blink-reviews, aboxhall, eae+blinkwatch, leviw+renderwatch, dglazkov+blink, dmazzoni, f(malita), jchaffraix+rendering, pdr, Stephen Chennney

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

Add toSVGImage fuction, and use it as much as we can. It has type checking assertions, and also it will help to find bad-cast bugs. BUG=N/A Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157628

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -3 lines)			Patch
M	Source/core/accessibility/AccessibilityRenderObject.cpp	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	Source/core/rendering/RenderImage.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/svg/graphics/SVGImage.h	View	1 chunk	+6 lines, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

gyuyoung-inactive

I feel to continue to clear static_cast<> though I don't find a nice auto-generation method ...

7 years, 3 months ago (2013-09-11 13:32:02 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/24071003/1

7 years, 3 months ago (2013-09-11 21:34:43 UTC) #3

Message was sent while issue was closed.

Change committed as 157628