Record scheme of the data reduction proxy server

Record scheme of the data reduction proxy server

UMA is added which records the scheme of the data reduction
proxy server used. This would be used for determining how
many requests were successfully fetched using HTTPS data
reduction proxy vs. QUIC data reduction proxy.

BUG=654793
Committed: https://crrev.com/f3798161a835bcfd9b257074093b4a44422d9a1a
Cr-Commit-Position: refs/heads/master@{#424764}

[tbansal1, 2016-10-11 01:26:00]

The CQ bit was checked by tbansal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-11 01:26:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-11 01:52:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-11 01:52:26]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[tbansal1, 2016-10-11 02:05:41]

The CQ bit was checked by tbansal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-11 02:06:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-11 03:00:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-11 03:00:56]

Dry run: This issue passed the CQ dry run.

[tbansal1, 2016-10-11 16:39:52]

The CQ bit was checked by tbansal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-11 16:40:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tbansal1, 2016-10-11 16:42:32]

The CQ bit was checked by tbansal@chromium.org to run a CQ dry run

[tbansal1, 2016-10-11 16:42:40]

Patchset #1 (id:1) has been deleted

[tbansal1, 2016-10-11 16:42:45]

Patchset #1 (id:20001) has been deleted

[tbansal1, 2016-10-11 16:42:50]

Patchset #1 (id:40001) has been deleted

[commit-bot: I haz the power, 2016-10-11 16:42:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tbansal1, 2016-10-11 16:48:20]

Description was changed from

==========
Record scheme of the data reduction proxy server

BUG=
==========

to

==========
Record scheme of the data reduction proxy server

UMA is added which records the scheme of the data reduction
proxy server used. This would be used for determining how 
many requests were successfully fetched using HTTPS data
reduction proxy vs. QUIC data reduction proxy.

BUG=654793
==========

[tbansal1, 2016-10-11 16:48:37]

tbansal@chromium.org changed reviewers:
+ megjablon@chromium.org

[tbansal1, 2016-10-11 16:48:38]

megjablon: ptal. thanks.

[commit-bot: I haz the power, 2016-10-11 16:56:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-11 16:56:11]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)

[megjablon, 2016-10-11 22:12:04]

https://chromiumcodereview.appspot.com/2407073002/diff/60001/components/data_...
File
components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_stats_unittest.cc
(right):

https://chromiumcodereview.appspot.com/2407073002/diff/60001/components/data_...
components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_stats_unittest.cc:571:
} tests[] = {{net::ProxyServer::SCHEME_HTTP, 1},
Should you add a test for unknown?

[megjablon, 2016-10-11 22:17:07]

https://chromiumcodereview.appspot.com/2407073002/diff/60001/components/data_...
File
components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_stats_unittest.cc
(right):

https://chromiumcodereview.appspot.com/2407073002/diff/60001/components/data_...
components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_stats_unittest.cc:64:
net::ProxyServer GetProxyWithScheme(net::ProxyServer::Scheme scheme) {
#include "net/proxy/proxy_server.h"

[tbansal1, 2016-10-11 22:34:43]

megjablon: ptal. Thanks.

https://codereview.chromium.org/2407073002/diff/60001/components/data_reducti...
File
components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_stats_unittest.cc
(right):

https://codereview.chromium.org/2407073002/diff/60001/components/data_reducti...
components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_stats_unittest.cc:64:
net::ProxyServer GetProxyWithScheme(net::ProxyServer::Scheme scheme) {
On 2016/10/11 22:17:07, megjablon wrote:
> #include "net/proxy/proxy_server.h"

Done.

https://codereview.chromium.org/2407073002/diff/60001/components/data_reducti...
components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_stats_unittest.cc:571:
} tests[] = {{net::ProxyServer::SCHEME_HTTP, 1},
On 2016/10/11 22:12:04, megjablon wrote:
> Should you add a test for unknown?

That will trigger a NOTREACHED(). So, restricted the test to release versions.

[tbansal1, 2016-10-11 22:41:00]

The CQ bit was checked by tbansal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-11 22:41:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[megjablon, 2016-10-11 22:49:00]

lgtm

[tbansal1, 2016-10-11 22:49:30]

tbansal@chromium.org changed reviewers:
+ asvitkine@chromium.org

[tbansal1, 2016-10-11 22:49:30]

asvitkine: ptal at histograms.xml. Thanks.

[commit-bot: I haz the power, 2016-10-11 22:54:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-11 22:54:36]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[tbansal1, 2016-10-12 04:46:18]

The CQ bit was checked by tbansal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-12 04:46:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-12 05:02:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-12 05:03:00]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[Alexei Svitkine (slow), 2016-10-12 16:38:22]

lgtm

[tbansal1, 2016-10-12 16:41:18]

The CQ bit was checked by tbansal@chromium.org

[tbansal1, 2016-10-12 16:41:18]

The patchset sent to the CQ was uploaded after l-g-t-m from
megjablon@chromium.org
Link to the patchset: https://codereview.chromium.org/2407073002/#ps100001
(title: "Add missing include")

[commit-bot: I haz the power, 2016-10-12 16:41:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-12 16:48:44]

Description was changed from

==========
Record scheme of the data reduction proxy server

UMA is added which records the scheme of the data reduction
proxy server used. This would be used for determining how 
many requests were successfully fetched using HTTPS data
reduction proxy vs. QUIC data reduction proxy.

BUG=654793
==========

to

==========
Record scheme of the data reduction proxy server

UMA is added which records the scheme of the data reduction
proxy server used. This would be used for determining how 
many requests were successfully fetched using HTTPS data
reduction proxy vs. QUIC data reduction proxy.

BUG=654793
==========

[commit-bot: I haz the power, 2016-10-12 16:48:45]

Committed patchset #3 (id:100001)

[commit-bot: I haz the power, 2016-10-12 17:49:08]

Description was changed from

==========
Record scheme of the data reduction proxy server

UMA is added which records the scheme of the data reduction
proxy server used. This would be used for determining how 
many requests were successfully fetched using HTTPS data
reduction proxy vs. QUIC data reduction proxy.

BUG=654793
==========

to

==========
Record scheme of the data reduction proxy server

UMA is added which records the scheme of the data reduction
proxy server used. This would be used for determining how
many requests were successfully fetched using HTTPS data
reduction proxy vs. QUIC data reduction proxy.

BUG=654793

Committed: https://crrev.com/f3798161a835bcfd9b257074093b4a44422d9a1a
Cr-Commit-Position: refs/heads/master@{#424764}
==========

[commit-bot: I haz the power, 2016-10-12 17:49:13]

Patchset 3 (id:??) landed as
https://crrev.com/f3798161a835bcfd9b257074093b4a44422d9a1a
Cr-Commit-Position: refs/heads/master@{#424764}