Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 240703004: Fix the remaining subpixel antialiasing bugs in the notification center. (Closed)

Created:
6 years, 8 months ago by dewittj
Modified:
6 years, 8 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews
Visibility:
Public.

Description

Fix the remaining subpixel antialiasing bugs in the notification center. This addresses bad text rendering in the following places: * The "Chrome Notifications" label * The "Nothing to see here, move along" label * The "Settings" label * The "Allow notifications from the following" settings label * The user selection drop down * The app selector buttons within settings. BUG=362369, 335794 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=264607

Patch Set 1 #

Total comments: 4

Patch Set 2 : Address nits. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+142 lines, -26 lines) Patch
A ui/message_center/cocoa/opaque_views.h View 1 1 chunk +36 lines, -0 lines 0 comments Download
A ui/message_center/cocoa/opaque_views.mm View 1 1 chunk +63 lines, -0 lines 0 comments Download
M ui/message_center/cocoa/settings_controller.h View 2 chunks +2 lines, -1 line 0 comments Download
M ui/message_center/cocoa/settings_controller.mm View 1 5 chunks +10 lines, -10 lines 0 comments Download
M ui/message_center/cocoa/settings_entry_view.mm View 1 4 chunks +22 lines, -2 lines 0 comments Download
M ui/message_center/cocoa/tray_view_controller.mm View 1 3 chunks +7 lines, -13 lines 0 comments Download
M ui/message_center/message_center.gyp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
dewittj
6 years, 8 months ago (2014-04-17 01:43:38 UTC) #1
Robert Sesek
LGTM w/ nits https://codereview.chromium.org/240703004/diff/1/ui/message_center/cocoa/opaque_views.h File ui/message_center/cocoa/opaque_views.h (right): https://codereview.chromium.org/240703004/diff/1/ui/message_center/cocoa/opaque_views.h#newcode33 ui/message_center/cocoa/opaque_views.h:33: - (id)initWithFrame:(NSRect)frameRect andColor:(NSColor*)color; andColor: -> backgroundColor: ...
6 years, 8 months ago (2014-04-17 13:31:51 UTC) #2
dewittj
https://codereview.chromium.org/240703004/diff/1/ui/message_center/cocoa/opaque_views.h File ui/message_center/cocoa/opaque_views.h (right): https://codereview.chromium.org/240703004/diff/1/ui/message_center/cocoa/opaque_views.h#newcode33 ui/message_center/cocoa/opaque_views.h:33: - (id)initWithFrame:(NSRect)frameRect andColor:(NSColor*)color; On 2014/04/17 13:31:51, rsesek wrote: > ...
6 years, 8 months ago (2014-04-17 16:58:57 UTC) #3
dewittj
The CQ bit was checked by dewittj@chromium.org
6 years, 8 months ago (2014-04-17 16:59:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dewittj@chromium.org/240703004/20001
6 years, 8 months ago (2014-04-17 16:59:39 UTC) #5
commit-bot: I haz the power
6 years, 8 months ago (2014-04-17 19:19:52 UTC) #6
Message was sent while issue was closed.
Change committed as 264607

Powered by Google App Engine
This is Rietveld 408576698