Issue 2407003003: 32.Refactoring in preparation for SpdyHeaderBlock cleanup.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2407003003: 32.Refactoring in preparation for SpdyHeaderBlock cleanup. (Closed)

Created:
4 years, 2 months ago by Zhongyi Shi

Modified:
4 years, 2 months ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

32.Refactoring in preparation for SpdyHeaderBlock cleanup. relnote: Handles more edge cases in SpdyBalsaUtils::RequestHeadersToSpdyHeaders. Not protected. Merge internal change: 135145341 BUG=

Patch Set 1 #

Created: 4 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+45 lines, -0 lines)			Patch
	M	net/tools/quic/spdy_balsa_utils.cc	View		1 chunk	+14 lines, -0 lines	0 comments	Download
	M	net/tools/quic/spdy_balsa_utils_test.cc	View		1 chunk	+31 lines, -0 lines	0 comments	Download

Depends on Patchset:

Issue 2403983002 Patch 1

Dependent Patchsets:

Issue 2404003002 Patch 1

Messages

Total messages: 3 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Ryan Hamilton

4 years, 2 months ago (2016-10-10 21:52:37 UTC) #3

lgtm, but not sure that "32. " belongs in the CL description.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages