Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2406993002:
MD Settings: Add style for disabled <select>. (Closed)
|
Created:
4 years, 2 months ago by dpapad Modified:
4 years, 2 months ago Reviewers:
dschuyler CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionMD Settings: Add style for disabled <select>.
BUG=654089
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Committed: https://crrev.com/efdb4d3dcb3d5e5af6783eb6b895f44d79da5c21
Cr-Commit-Position: refs/heads/master@{#424330}
Patch Set 1 #
Total comments: 4
Patch Set 2 : Addressing comment. #
Total comments: 2
Patch Set 3 : Nit. #Patch Set 4 : No diff #Messages
Total messages: 20 (10 generated)
Description was changed from ========== MD Settings: Add style for disabled <select>. BUG=654089 ========== to ========== MD Settings: Add style for disabled <select>. BUG=654089 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
dpapad@chromium.org changed reviewers: + michaelpg@chromium.org
Chose values to match paper-dropdown-menu disabled look. See screenshot at http://imgur.com/a/7fjEi.
dpapad@chromium.org changed reviewers: + dschuyler@chromium.org - michaelpg@chromium.org
Re-directing to @dschuyler, since @michaelpg is OOO.
https://codereview.chromium.org/2406993002/diff/1/chrome/browser/resources/se... File chrome/browser/resources/settings/md_select_css.html (right): https://codereview.chromium.org/2406993002/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/md_select_css.html:29: .md-select[disabled] { Please make a comment about where these values came from (so I don't wrongly change them to something else :) ). https://codereview.chromium.org/2406993002/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/md_select_css.html:30: border-bottom: 1px dashed #737373; Maybe the 737373 could be replace with a var() maybe --secondary-text-color.
Patchset #2 (id:20001) has been deleted
https://codereview.chromium.org/2406993002/diff/1/chrome/browser/resources/se... File chrome/browser/resources/settings/md_select_css.html (right): https://codereview.chromium.org/2406993002/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/md_select_css.html:29: .md-select[disabled] { On 2016/10/10 at 23:56:26, dschuyler wrote: > Please make a comment about where these values > came from (so I don't wrongly change them > to something else :) ). Done. https://codereview.chromium.org/2406993002/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/md_select_css.html:30: border-bottom: 1px dashed #737373; On 2016/10/10 at 23:56:26, dschuyler wrote: > Maybe the 737373 could be replace with a var() > maybe --secondary-text-color. Done, thanks for the suggestion, I was suspecting that there must be a var where #737373 comes from.
lgtm https://codereview.chromium.org/2406993002/diff/40001/chrome/browser/resource... File chrome/browser/resources/settings/md_select_css.html (right): https://codereview.chromium.org/2406993002/diff/40001/chrome/browser/resource... chrome/browser/resources/settings/md_select_css.html:29: /* Mirroring paper-dropdown-menu disabled style */ nit: period at the end style. */
The CQ bit was checked by dpapad@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dschuyler@chromium.org Link to the patchset: https://codereview.chromium.org/2406993002/#ps60001 (title: "Nit.")
The CQ bit was unchecked by commit-bot@chromium.org
This CL has an open dependency (Issue 2409813002 Patch 1). Please resolve the dependency and try again. If you are sure that there is no real dependency, please use one of the options listed in https://goo.gl/9Es4OR to land the CL.
The CQ bit was checked by dpapad@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dschuyler@chromium.org Link to the patchset: https://codereview.chromium.org/2406993002/#ps80001 (title: "No diff")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2406993002/diff/40001/chrome/browser/resource... File chrome/browser/resources/settings/md_select_css.html (right): https://codereview.chromium.org/2406993002/diff/40001/chrome/browser/resource... chrome/browser/resources/settings/md_select_css.html:29: /* Mirroring paper-dropdown-menu disabled style */ On 2016/10/11 at 00:12:41, dschuyler wrote: > nit: period at the end > style. */ Done.
Message was sent while issue was closed.
Committed patchset #4 (id:80001)
Message was sent while issue was closed.
Description was changed from ========== MD Settings: Add style for disabled <select>. BUG=654089 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== MD Settings: Add style for disabled <select>. BUG=654089 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/efdb4d3dcb3d5e5af6783eb6b895f44d79da5c21 Cr-Commit-Position: refs/heads/master@{#424330} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/efdb4d3dcb3d5e5af6783eb6b895f44d79da5c21 Cr-Commit-Position: refs/heads/master@{#424330} |
