Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(470)

Issue 2406983002: Filter font list, use Fontconfig and build on Ozone (Closed)

Created:
4 years, 2 months ago by hshi1
Modified:
4 years, 2 months ago
CC:
chromium-reviews, jam, darin-cc_chromium.org
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

Filter font list, use Fontconfig and build on Ozone Since we dropped support for rendering Type 1 fonts in Chrome, we should filter the list of fonts that can be configured as defaults to only display fonts that have the right font format, i.e. TrueType or CFF. A a side effect, this allows us to build the font list enumeration for ozone as well, as it is only dependent on Fontconfig after this CL, not dependent on Pango anymore. For backwards compability with the old implementation, we're adding three Fontconfig alias families Sans, Serif and Monospace to the list, since our default settings on Linux included the "Monospace" family for the fixed width font. BUG=630508, 457307 TBR=avi@chromium.org TBR=derat@chromium.org TBR=spang@chromium.org NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2278143002 Cr-Commit-Position: refs/heads/master@{#414677} (cherry picked from commit e70ca0a2e161e47a7f36f94c19e5a9c6448a15b9)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -83 lines) Patch
M content/common/BUILD.gn View 2 chunks +7 lines, -13 lines 0 comments Download
A content/common/font_list_fontconfig.cc View 1 chunk +72 lines, -0 lines 0 comments Download
D content/common/font_list_ozone.cc View 1 chunk +0 lines, -15 lines 0 comments Download
D content/common/font_list_pango.cc View 1 chunk +0 lines, -44 lines 0 comments Download
M content/content_common.gypi View 3 chunks +1 line, -11 lines 0 comments Download

Messages

Total messages: 9 (7 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2406983002/1
4 years, 2 months ago (2016-10-10 19:41:12 UTC) #7
commit-bot: I haz the power
4 years, 2 months ago (2016-10-10 19:45:12 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698